Skip to content

Commit

Permalink
Merge pull request #30 from GispoCoding/23-break-up-trajectorypy
Browse files Browse the repository at this point in the history 
23 break up trajectorypy
  • Loading branch information
@JuhoErvasti
JuhoErvasti authored Oct 28, 2024
2 parents 2247a48 + 79d537f commit 3412c5e
Show file tree
Hide file tree
Showing 12 changed files with 835 additions and 780 deletions.
204 changes: 5 additions & 199 deletions fvh3t/core/gate.py
View file
Original file line number Diff line number Diff line change
@@ -1,133 +1,16 @@
from __future__ import annotations

from enum import Enum
from typing import TYPE_CHECKING

from fvh3t.core.exceptions import InvalidDirectionException, InvalidGeometryTypeException, InvalidLayerException
from fvh3t.core.exceptions import InvalidDirectionException, InvalidGeometryTypeException

if TYPE_CHECKING:
from fvh3t.core.trajectory import Trajectory, TrajectoryLayer, TrajectorySegment
from fvh3t.core.trajectory import Trajectory
from fvh3t.core.trajectory_layer import TrajectoryLayer

from qgis.core import QgsFeatureSource, QgsGeometry, QgsPointXY, QgsVectorLayer, QgsWkbTypes
from qgis.core import QgsGeometry, QgsPointXY, QgsWkbTypes


class RelativeDirection(Enum):
LEFT = 1
RIGHT = 2
COLLINEAR = 3
UNKNOWN = 4


class GateSegment:
"""
Class representing one segment of a Gate.
"""

def __init__(self, point_a: QgsPointXY, point_b: QgsPointXY) -> None:
self.__point_a: QgsPointXY = point_a
self.__point_b: QgsPointXY = point_b

self.__geom = QgsGeometry.fromPolylineXY([point_a, point_b])

def point_a(self) -> QgsPointXY:
return self.__point_a

def point_b(self) -> QgsPointXY:
return self.__point_b

def geometry(self) -> QgsGeometry:
return self.__geom

def trajectory_segment_crosses(self, traj_seg: TrajectorySegment, *, counts_left: bool, counts_right: bool) -> bool:
crosses = self.__geom.crosses(traj_seg.as_geometry())

if not crosses:
if self.__geom.intersects(traj_seg.as_geometry()):
# TODO: Handle case where the segment doesn't cross this segment
# but instead intersects it. In practice this means that when a trajectory
# has a vertex exactly on this segment we cannot rely on calculating
# the crossing direction from the singular segment.
# Realistically the chances of a trajectory node landing exactly on the
# gate segment should be extremely rare, but regardless we do need
# to deal with that... BUT right now in the interest of moving things
# forwards I'm leaving this as a TODO
msg = "Cannot determine direction from trajectory segment!"
raise InvalidDirectionException(msg)

return False

if counts_left and counts_right:
return True

crosses_from: RelativeDirection = self.trajectory_segment_crosses_from(traj_seg)

if counts_left and crosses_from == RelativeDirection.LEFT:
return True

return counts_right and crosses_from == RelativeDirection.RIGHT

def trajectory_segment_crosses_from(self, segment: TrajectorySegment) -> RelativeDirection:
node_a_dir: RelativeDirection = self.point_relative_direction(segment.node_a.point)
node_b_dir: RelativeDirection = self.point_relative_direction(segment.node_b.point)

crosses_from: RelativeDirection = RelativeDirection.UNKNOWN

# node A should always be the first node, timewise

if node_a_dir == RelativeDirection.LEFT and node_b_dir == RelativeDirection.RIGHT:
crosses_from = RelativeDirection.LEFT
elif node_a_dir == RelativeDirection.RIGHT and node_b_dir == RelativeDirection.LEFT:
crosses_from = RelativeDirection.RIGHT
elif node_a_dir == RelativeDirection.COLLINEAR and node_b_dir == RelativeDirection.RIGHT:
crosses_from = RelativeDirection.LEFT
elif (
node_a_dir == RelativeDirection.COLLINEAR
and node_b_dir == RelativeDirection.LEFT
or node_a_dir == RelativeDirection.RIGHT
and node_b_dir == RelativeDirection.COLLINEAR
):
crosses_from = RelativeDirection.RIGHT
elif node_a_dir == RelativeDirection.LEFT and node_b_dir == RelativeDirection.COLLINEAR:
crosses_from = RelativeDirection.LEFT
elif node_a_dir == RelativeDirection.COLLINEAR and node_b_dir == RelativeDirection.COLLINEAR:
# i.e. the trajectory segment is exactly
# on this gate segment.
# realistically this should be extremely rare,
# but regardless we have to deal with this
# edge case.
crosses_from = RelativeDirection.COLLINEAR
elif node_a_dir == node_b_dir:
# it is assumed that it has already been checked
# that the trajectory segment intersects
# this gate segment.
# therefore this should never happen and
# we throw an error

msg = "Both nodes cannot be on the same side!"
raise InvalidDirectionException(msg)
else:
# this would require either dir
# being UNKNOWN which should never
# happen, so throw an error

msg = "Directions cannot be unkown!"
raise InvalidDirectionException(msg)

return crosses_from

def point_relative_direction(self, point: QgsPointXY) -> RelativeDirection:
pos: float = (point.x() - self.__point_a.x()) * (self.__point_b.y() - self.__point_a.y()) - (
point.y() - self.__point_a.y()
) * (self.__point_b.x() - self.__point_a.x())

if pos > 0:
direction = RelativeDirection.RIGHT
elif pos < 0:
direction = RelativeDirection.LEFT
else:
direction = RelativeDirection.COLLINEAR

return direction
from fvh3t.core.gate_segment import GateSegment


class Gate:
Expand Down Expand Up @@ -203,80 +86,3 @@ def count_trajectories(self, trajectories: tuple[Trajectory, ...]) -> None:
)
if crosses:
self.__trajectory_count += 1


class GateLayer:
"""
Wrapper around a QgsVectorLayer object from which gates
can be instantiated, i.e.
1. is a line layer
2. has a valid "counts left" field
2. has a valid "counts right" field
"""

def __init__(
self,
layer: QgsVectorLayer,
counts_left_field: str,
counts_right_field: str,
) -> None:
self.__layer: QgsVectorLayer = layer
self.__counts_left_field = counts_left_field
self.__counts_right_field = counts_right_field

if not self.is_valid():
msg = "GateLayer could not be properly created!"
raise InvalidLayerException(msg)

self.__gates: tuple[Gate, ...] = ()
self.create_gates()

def create_gates(self) -> None:
counts_left_field_idx: int = self.__layer.fields().indexOf(self.__counts_left_field)
counts_right_field_idx: int = self.__layer.fields().indexOf(self.__counts_right_field)

# TODO: Check that these are bool fields

gates: list[Gate] = []

for feature in self.__layer.getFeatures():
counts_left: bool = feature[counts_left_field_idx]
counts_right: bool = feature[counts_right_field_idx]

gate = Gate(feature.geometry(), counts_left=counts_left, counts_right=counts_right)

gates.append(gate)

self.__gates = tuple(gates)

def gates(self) -> tuple[Gate, ...]:
return self.__gates

def is_valid(self) -> bool:
is_layer_valid: bool = self.__layer.isValid()
if not is_layer_valid:
msg = "Layer is not valid."
raise ValueError(msg)

is_point_layer: bool = self.__layer.geometryType() == QgsWkbTypes.GeometryType.LineGeometry
if not is_point_layer:
msg = "Layer is not a point layer."
raise ValueError(msg)

has_features: bool = self.__layer.hasFeatures() == QgsFeatureSource.FeatureAvailability.FeaturesAvailable
if not has_features:
msg = "Layer has no features."
raise ValueError(msg)

counts_left_field_exists: bool = self.__layer.fields().indexFromName(self.__counts_left_field) != -1
if not counts_left_field_exists:
msg = "Counts left field not found in the layer."
raise ValueError(msg)

counts_right_field_exists: bool = self.__layer.fields().indexFromName(self.__counts_right_field) != -1
if not counts_right_field_exists:
msg = "Counts right field not found in the layer."
raise ValueError(msg)

return True
83 changes: 83 additions & 0 deletions fvh3t/core/gate_layer.py
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
from __future__ import annotations

from qgis.core import QgsFeatureSource, QgsVectorLayer, QgsWkbTypes

from fvh3t.core.exceptions import InvalidLayerException
from fvh3t.core.gate import Gate


class GateLayer:
"""
Wrapper around a QgsVectorLayer object from which gates
can be instantiated, i.e.
1. is a line layer
2. has a valid "counts left" field
2. has a valid "counts right" field
"""

def __init__(
self,
layer: QgsVectorLayer,
counts_left_field: str,
counts_right_field: str,
) -> None:
self.__layer: QgsVectorLayer = layer
self.__counts_left_field = counts_left_field
self.__counts_right_field = counts_right_field

if not self.is_valid():
msg = "GateLayer could not be properly created!"
raise InvalidLayerException(msg)

self.__gates: tuple[Gate, ...] = ()
self.create_gates()

def create_gates(self) -> None:
counts_left_field_idx: int = self.__layer.fields().indexOf(self.__counts_left_field)
counts_right_field_idx: int = self.__layer.fields().indexOf(self.__counts_right_field)

# TODO: Check that these are bool fields

gates: list[Gate] = []

for feature in self.__layer.getFeatures():
counts_left: bool = feature[counts_left_field_idx]
counts_right: bool = feature[counts_right_field_idx]

gate = Gate(feature.geometry(), counts_left=counts_left, counts_right=counts_right)

gates.append(gate)

self.__gates = tuple(gates)

def gates(self) -> tuple[Gate, ...]:
return self.__gates

def is_valid(self) -> bool:
is_layer_valid: bool = self.__layer.isValid()
if not is_layer_valid:
msg = "Layer is not valid."
raise ValueError(msg)

is_point_layer: bool = self.__layer.geometryType() == QgsWkbTypes.GeometryType.LineGeometry
if not is_point_layer:
msg = "Layer is not a point layer."
raise ValueError(msg)

has_features: bool = self.__layer.hasFeatures() == QgsFeatureSource.FeatureAvailability.FeaturesAvailable
if not has_features:
msg = "Layer has no features."
raise ValueError(msg)

counts_left_field_exists: bool = self.__layer.fields().indexFromName(self.__counts_left_field) != -1
if not counts_left_field_exists:
msg = "Counts left field not found in the layer."
raise ValueError(msg)

counts_right_field_exists: bool = self.__layer.fields().indexFromName(self.__counts_right_field) != -1
if not counts_right_field_exists:
msg = "Counts right field not found in the layer."
raise ValueError(msg)

return True
Loading

0 comments on commit 3412c5e

Please sign in to comment.