フォームドメインのリファクタリング #634
Merged
フォームドメインのリファクタリング #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rito528
force-pushed
the
refactor/form-domain
branch
from
fb0588c to
5cb7ed4
Compare
…WithContext に包んで返す
There was a problem hiding this comment.
Copilot reviewed 90 out of 105 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- server/domain/src/form/message.rs: Evaluated as low risk
- server/domain/src/form/answer/settings.rs: Evaluated as low risk
- server/domain/src/form.rs: Evaluated as low risk
- server/domain/src/form/answer/models.rs: Evaluated as low risk
- server/domain/src/repository/form/answer_label_repository.rs: Evaluated as low risk
- server/domain/src/repository/form.rs: Evaluated as low risk
- server/domain/src/form/comment/models.rs: Evaluated as low risk
- server/domain/src/repository.rs: Evaluated as low risk
- server/domain/src/notification/models.rs: Evaluated as low risk
- server/domain/Cargo.toml: Evaluated as low risk
- server/domain/src/form/question.rs: Evaluated as low risk
- server/domain/src/form/comment.rs: Evaluated as low risk
- server/Makefile.toml: Evaluated as low risk
- server/domain/src/form/answer.rs: Evaluated as low risk
- server/domain/src/form/question/models.rs: Evaluated as low risk
Comments suppressed due to low confidence (4)
server/domain/src/form/service.rs:33
- [nitpick] The function name 'embedded_answer_title' is ambiguous. It should be renamed to 'generate_embedded_answer_title' for better clarity.
fn embedded_answer_title(
server/domain/src/form/comment/service.rs:39
- The logical combination of AND (&&) and OR (||) operators might lead to unintended behavior. Consider adding parentheses to make the logic explicit:
&& (self.commented_by().id == actor.id || actor.role == Administrator).
&& self.commented_by().id == actor.id || actor.role == Administrator
server/domain/src/form/comment/service.rs:49
- The logical combination of AND (&&) and OR (||) operators might lead to unintended behavior. Consider adding parentheses to make the logic explicit:
&& (self.commented_by().id == actor.id || actor.role == Administrator).
&& self.commented_by().id == actor.id || actor.role == Administrator
server/domain/src/form/answer/settings/models.rs:15
- The
DerivingViaattribute is incorrectly formatted. It should be#[deriving(Clone, From, Into, IntoInner, Serialize, Deserialize)].
#[deriving(From, Into, IntoInner, Serialize(via: Option::<NonEmptyString>), Deserialize(via: Option::<NonEmptyString>))]
There was a problem hiding this comment.
Copilot reviewed 105 out of 105 changed files in this pull request and generated no comments.
|
一旦この PR の目的だったフォームドメインの整理は達成できたのでマージします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
フォームに付随する機能すべてがフォームドメインとしてまとめられていて、これによって不都合が出てきたのでリファクタリングします