[AND-277] Avatar component factories #5596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size Comparison 📏
|
andremion
force-pushed
the
AND-277-useravatar-stateless-component
branch
from
a4cbedd to
c98c7c8
Compare
andremion
force-pushed
the
AND-277-useravatar-stateless-component
branch
from
c98c7c8 to
2100b11
Compare
andremion
force-pushed
the
AND-277-useravatar-stateless-component
branch
from
8a82f0b to
3ee688a
Compare
andremion
force-pushed
the
AND-277-useravatar-stateless-component
branch
from
3ee688a to
c9eb9df
Compare
JcMinarro
reviewed
Jan 31, 2025
Comment on lines
140
to
141
| UserAvatar( | ||
| Avatar( |
There was a problem hiding this comment.
Why are we switching from UserAvatar to Avatar?
Shouldn't we use the factory here?
There was a problem hiding this comment.
I replaced all calls from UserAvatar to Avatar when showOnlineIndicator = false
That means it's not meant to show the online indicator at any case.
There was a problem hiding this comment.
The Avatar factory is not done yet. As I mentioned, it's a WIP. PR is a draft yet
JcMinarro
reviewed
Jan 31, 2025
Comment on lines
84
to
86
| UserAvatar( | ||
| Avatar( |
There was a problem hiding this comment.
Same here.
Shouldn't we use ChatTheme.componentFactory.UserAvatar()?? 🤔
There was a problem hiding this comment.
Answered above 🙂
andremion
force-pushed
the
AND-277-useravatar-stateless-component
branch
from
c9eb9df to
44388f2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Provide default factories for the avatar components:
UserAvatar,ChannelAvatar, andAvatarUnrelated changes
UserAvatarusages withAvatarwhenshowOnlineIndicator = false, which means we can useAvatardirectly.🎨 UI Changes
Screen_recording_20250131_162928.webm
Screen_recording_20250131_163229.webm
Screen_recording_20250131_163536.webm
Screen_recording_20250131_163758.webm