Cards, Orgs, and PublisherLists #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgading
added a commit
that referenced
this pull request
May 18, 2022
* Add USWDS Card component * Update button action to null by default * Adds Organization component with docz and tests * Move PublisherList to templates and set with best practice for ease of use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #120
This PR adds a new Cards component from the USWDS. Using that card as a template, this PR updates the Organization component to a bit of an opinionated take on how Organizations should work both on a Publisher page and on the sidebar of a dataset.
It also moves the PublisherList from components to templates. The PublisherList is now an opinionated list of Organizations that could be dropped on a Publisher page in data-catalog-app.