Skip to content

Commit

Permalink
Merge branch 'stable-3.9' into stable-3.10
Browse files Browse the repository at this point in the history
* stable-3.9:
  Update permissions object to trigger re-render
  Reduce concurrency on frontend tests.
  Bump JGit to 3a7a9cb0e (stable-6.10 tip)

Change-Id: I24f7eda88fd188e518964f8c751c5b528985f931
Release-Notes: skip
  • Loading branch information
Nasser Grainawi committed Nov 6, 2024
2 parents 826c67d + b2131c6 commit 469b56a
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
2 changes: 1 addition & 1 deletion modules/jgit
Submodule jgit updated from 1cd87a to 3a7a9c
12 changes: 10 additions & 2 deletions polygerrit-ui/app/elements/admin/gr-permission/gr-permission.ts
Original file line number Diff line number Diff line change
Expand Up @@ -353,8 +353,16 @@ export class GrPermission extends LitElement {
if (!this.permission) {
return;
}
this.permission.value.modified = true;
this.permission.value.exclusive = (e.target as HTMLInputElement).checked;
// Update entire permission object to trigger a re-render since permission
// is marked as @property
this.permission = {
...this.permission,
value: {
...this.permission.value,
modified: true,
exclusive: (e.target as HTMLInputElement).checked,
},
};
// Allows overall access page to know a change has been made.
fire(this, 'access-modified', {});
}
Expand Down
3 changes: 3 additions & 0 deletions polygerrit-ui/web-test-runner.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ function testRunnerHtmlFactory() {

/** @type {import('@web/test-runner').TestRunnerConfig} */
const config = {
// TODO: https://g-issues.gerritcodereview.com/issues/365565157 - undo the
// change once the underlying issue is fixed.
concurrency: 1,
files: [
"app/**/*_test.{ts,js}",
"!**/node_modules/**/*",
Expand Down

0 comments on commit 469b56a

Please sign in to comment.