Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mobile menu #1010

Merged
merged 7 commits into from
Jan 2, 2024
Merged

Update mobile menu #1010

merged 7 commits into from
Jan 2, 2024

Conversation

dtrucs
Copy link
Collaborator

@dtrucs dtrucs commented Dec 29, 2023 •
edited
Loading

✨ Improvements

  • Move the mobile menu in the <header> tag

🔧 Maintenance

  • Upgrade react-accessible-accordion package to 5.0.0
  • Upgrade react-burger-menu package to 3.0.9

🐛 Fixes

@dtrucs dtrucs requested a review from a team December 29, 2023 15:18
babastienne
babastienne requested changes Jan 2, 2024
View reviewed changes
Copy link
Member

@babastienne babastienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog and documentation ? Can you provide in your description some screenshots to illustrate before / after result ?

@dtrucs
Copy link
Collaborator Author

dtrucs commented Jan 2, 2024

@babastienne i just edited the PR description.
Nothing to add to the documentation, the changelog is updated at the time of release.

@dtrucs dtrucs force-pushed the Update-mobile-menu branch from 1f0a333 to d355a4d Compare January 2, 2024 10:18
@babastienne babastienne merged commit 6408a16 into main Jan 2, 2024
1 check passed
@dtrucs dtrucs deleted the Update-mobile-menu branch January 15, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babastienne babastienne babastienne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Liste des langues en version mobile
2 participants
@dtrucs @babastienne