Fix custom XML file display in simulation environment #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Genesis-Embodied-AI#548 Add handling for `contype` and `conaffinity` attributes in the simulation environment. * Update `genesis/utils/mjcf.py` to parse `contype` and `conaffinity` attributes in the `parse_geom` function and set them to 0 if not specified. * Update `genesis/engine/entities/rigid_entity/rigid_entity.py` to handle `contype` and `conaffinity` attributes in the `_load_MJCF` method and pass them to the `RigidGeom` constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #548
Add handling for
contypeandconaffinityattributes in the simulation environment.genesis/utils/mjcf.pyto parsecontypeandconaffinityattributes in theparse_geomfunction and set them to 0 if not specified.genesis/engine/entities/rigid_entity/rigid_entity.pyto handlecontypeandconaffinityattributes in the_load_MJCFmethod and pass them to theRigidGeomconstructor.