Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Added PID controller util, quadcopter PID controller, flight examples #501

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jebbrysacz
Copy link

Abstracting the need for individual rotor control for quadcopter through a pseudo-nested PID controller. Makes flying to a target or targets simple without the need for reinforcement learning. Example flight to targets is in examples/fly_route.py. Note that the parameters are tuned for flight, but not optimized.

Run with: python fly_route.py.

@zhouxian
Copy link
Collaborator

zhouxian commented Jan 8, 2025

could you move the pid controller into your example?
if we want to add a independent pid controller class, maybe we need to design more carefully

@KafuuChikai
Copy link
Contributor

Hi @jebbrysacz ,

We noticed that you've implemented a basic PID controller for your drone simulations. That's fantastic! 😀 We're also working on something similar and are looking to make it a bit more complex.

We're considering adding more realistic actuators, mixers, and advanced PID controllers with features like angular velocity loops, attitude loops, integral saturation, and even differentiable controllers. We're planning to migrate the work from Omnidrone to Genesis.

We'd love to hear your thoughts on this and learn about your plans. Perhaps there's an opportunity for us to collaborate and combine our efforts.

Looking forward to hearing from you!

Best regards,
Xian Wang

@jebbrysacz
Copy link
Author

could you move the pid controller into your example? if we want to add a independent pid controller class, maybe we need to design more carefully

Zhou, I've just moved the pid controller to the examples folder and deleted the file in utils. Please let me know if there's anything else.

@jebbrysacz
Copy link
Author

Hi @jebbrysacz ,

We noticed that you've implemented a basic PID controller for your drone simulations. That's fantastic! 😀 We're also working on something similar and are looking to make it a bit more complex.

We're considering adding more realistic actuators, mixers, and advanced PID controllers with features like angular velocity loops, attitude loops, integral saturation, and even differentiable controllers. We're planning to migrate the work from Omnidrone to Genesis.

We'd love to hear your thoughts on this and learn about your plans. Perhaps there's an opportunity for us to collaborate and combine our efforts.

Looking forward to hearing from you!

Best regards, Xian Wang

Hello Xian @KafuuChikai !

I was also planning to make my drone controller a bit more complex. I was first thinking of adding in nested pid capabilities for angular velocity and attitude to the original controller, although this may conflict with the way the simulation handles time stepping. After that I was planning to build a more complex control algorithm class, maybe model predictive control.

It sounds like you are planning to add in many more drone control features. I think a lot of the work I would like to accomplish aligns with what you all are doing. I'd be very excited to collaborate with you!! If you'd like, you can contact me at my email: [email protected]. I look forward to hearing back!!

Best,
Jeb Brysacz

@KafuuChikai
Copy link
Contributor

Hi @jebbrysacz ,
We noticed that you've implemented a basic PID controller for your drone simulations. That's fantastic! 😀 We're also working on something similar and are looking to make it a bit more complex.
We're considering adding more realistic actuators, mixers, and advanced PID controllers with features like angular velocity loops, attitude loops, integral saturation, and even differentiable controllers. We're planning to migrate the work from Omnidrone to Genesis.
We'd love to hear your thoughts on this and learn about your plans. Perhaps there's an opportunity for us to collaborate and combine our efforts.
Looking forward to hearing from you!
Best regards, Xian Wang

Hello Xian @KafuuChikai !

I was also planning to make my drone controller a bit more complex. I was first thinking of adding in nested pid capabilities for angular velocity and attitude to the original controller, although this may conflict with the way the simulation handles time stepping. After that I was planning to build a more complex control algorithm class, maybe model predictive control.

It sounds like you are planning to add in many more drone control features. I think a lot of the work I would like to accomplish aligns with what you all are doing. I'd be very excited to collaborate with you!! If you'd like, you can contact me at my email: [email protected]. I look forward to hearing back!!

Best, Jeb Brysacz

Hi Jeb,

Thank you for your interest in collaborating! We would be delighted to work with you and will be reaching out to you soon. In the meantime, please feel free to contact me at my email: [email protected].

Best regards,
Xian Wang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants