-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added example of setting projection using EPSG, and modified rgb_example to incorporate this #3622
base: main
Are you sure you want to change the base?
Conversation
…ed changes to rgb example to demonstrate it being used but the changes I made did not work
💖 Thanks for opening this pull request! 💖 Please make sure you read our contributing guidelines and abide by our code of conduct. A few things to keep in mind:
|
Hi @bwwjohnson, Regarding plotting features on top of the RGB image example (e.g., the built-in GMT coastlines) I am unsure, and I feel we should handle this in a second step. Please note, that some of us are currently preparing materials for AGU, so answers may be a bit delayed. Regarding the failing Style checks:
This indicates that your Python script has execution permission, which is not allowed here. |
Thanks Yvonne, noted about AGU! I think the EPSG specification not working is an upstream issue within GMT so not worth adding now. I will tidy up the EPSG projection example and remove the changes to rgb_example. |
I have converted to PR to draft status to save our CI resources. Please click the "Ready for review" when you think the PR is finished. Thanks. |
@bwwjohnson First of all, thank you for opening this PR. Since we're planning to release v0.14.0 at the end of this year, I'm wondering if you have time to finish this PR before the release date. |
Description of proposed changes
Two changes:
Unfortunately 2. has not worked yet for some reason as the region specification is throwing an error:
Could I get help with point 2. as I think it demonstrates the value of using EPSG to specify projections, and it is very useful to be able to plot additional features on top of pre-projected data. (e.g. example 28 on the OG GMT https://docs.generic-mapping-tools.org/latest/gallery/ex28.html).
Fixes #
Preview:
Reminders
Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash command is:
/format
: automatically format and lint the code