Skip to content

Commit

Permalink
Remove fitting optimization as it breaks regression tests. Needs more…
Browse files Browse the repository at this point in the history
… investigation
  • Loading branch information
DBerke committed Jan 17, 2024
1 parent 48652b1 commit 1c7c9c5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion gempy/library/wavecal.py
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,9 @@ def perform_piecewise_fit(model, peaks, arc_lines, pixel_start, kdsigma,
except ValueError:
pass
else:
if min(len(arc_lines), len(peaks)) > min_lines_per_fit:
# The commented-out line below speeds up fitting in some situations,
# but also breaks regression tests. More investigation needed. DB
# if min(len(arc_lines), len(peaks)) > min_lines_per_fit:
if p_lo < p0 <= pixel_start:
arc_line = arc_lines[matches[list(peaks).index(p_lo)]]
fits_to_do.append((p_lo, arc_line, dw))
Expand Down

0 comments on commit 1c7c9c5

Please sign in to comment.