fix(linter): remove all of any types

GemWallet · Dec 29, 2024 · da7b6cf · da7b6cf
1 parent d3671b1
commit da7b6cf
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 16 deletions.
diff --git a/packages/extension/src/components/molecules/DataCard/DataCard.tsx b/packages/extension/src/components/molecules/DataCard/DataCard.tsx
@@ -1,4 +1,4 @@
-import { FC, useEffect, useRef, useState } from 'react';
+import { FC, ReactNode, useEffect, useRef, useState } from 'react';
 
 import ChevronRightIcon from '@mui/icons-material/ChevronRight';
 import ExpandMoreIcon from '@mui/icons-material/ExpandMore';
@@ -7,7 +7,7 @@ import { IconButton, Paper, Typography } from '@mui/material';
 import { SECONDARY_GRAY } from '../../../constants';
 
 export interface DataCardProps {
-  formattedData: string;
+  formattedData: ReactNode;
   dataName?: string;
   isExpanded: boolean;
   setIsExpanded: (value: boolean) => void;

diff --git a/packages/extension/src/components/pages/Transaction/Transaction.tsx b/packages/extension/src/components/pages/Transaction/Transaction.tsx
@@ -159,7 +159,7 @@ export const Transaction: FC = () => {
 
     const transaction = buildPayment(
       {
-        ...parseBaseParamsFromStoredData(fetchedData),
+        ...parseBaseParamsFromStoredData(fetchedData as SendPaymentRequest),
         amount: amount ?? '0',
         destination: destination ?? '',
         ...(destinationTag && { destinationTag }),

diff --git a/packages/extension/src/hooks/useFetchFromSessionStorage/useFetchFromSessionStorage.ts b/packages/extension/src/hooks/useFetchFromSessionStorage/useFetchFromSessionStorage.ts
@@ -13,7 +13,7 @@ export const useFetchFromSessionStorage = (key?: string) => {
     const fetchData = async () => {
       try {
         if (key) {
-          const storedData = await loadFromChromeSessionStorage(key, true);
+          const storedData = await loadFromChromeSessionStorage<string>(key, true);
           if (storedData) {
             setFetchedData(JSON.parse(storedData));
           }

diff --git a/packages/extension/src/utils/baseParams.test.ts b/packages/extension/src/utils/baseParams.test.ts
@@ -1,4 +1,5 @@
 import {
+  AnyBaseTransactionParamsNew,
   getBaseFromParams,
   initialBaseTransactionParams,
   parseBaseParamsFromStoredData,
@@ -81,7 +82,7 @@ describe('parseBaseParamsFromURLParams', () => {
 
 describe('getBaseFromParams', () => {
   test('should get base transaction parameters from an object', () => {
-    const params = {
+    const params: AnyBaseTransactionParamsNew = {
       fee: '10',
       sequence: 1,
       accountTxnID: '123',
@@ -100,7 +101,7 @@ describe('getBaseFromParams', () => {
   });
 
   test('should handle undefined parameters', () => {
-    const params = {};
+    const params: AnyBaseTransactionParamsNew = {};
 
     const result = getBaseFromParams(params);
 
@@ -121,7 +122,7 @@ describe('getBaseFromParams', () => {
 
 describe('parseBaseParamsFromStoredData', () => {
   it('should parse all values correctly', () => {
-    const storedObject = {
+    const storedObject: AnyBaseTransactionParamsNew = {
       fee: '12',
       sequence: '2',
       accountTxnID: 'abc123',

diff --git a/packages/extension/src/utils/baseParams.ts b/packages/extension/src/utils/baseParams.ts
@@ -2,7 +2,6 @@ import { Memo, Signer } from '@gemwallet/constants';
 
 import { parseMemos, parseSigners } from './parseParams';
 import { checkFee } from './transaction';
-import { DeepPartialExcept } from '../types';
 
 export type BaseTransactionParamsNew = {
   fee?: string;
@@ -18,6 +17,20 @@ export type BaseTransactionParamsNew = {
   txnSignature?: string;
 };
 
+export type AnyBaseTransactionParamsNew = Partial<{
+  fee: string;
+  sequence: string | number;
+  accountTxnID: string;
+  lastLedgerSequence: string | number;
+  memos: Record<string, unknown>[] | unknown[] | Memo[];
+  networkID: string | number;
+  signers: Record<string, unknown>[] | unknown[] | Signer[];
+  sourceTag: string | number;
+  signingPubKey: string;
+  ticketSequence: string | number;
+  txnSignature: string;
+}>;
+
 export const parseBaseParamsFromURLParamsNew = (
   urlParams: URLSearchParams
 ): BaseTransactionParamsNew => {
@@ -56,13 +69,13 @@ export const parseBaseParamsFromURLParamsNew = (
 };
 
 export const parseBaseParamsFromStoredData = (
-  storedObject: DeepPartialExcept<BaseTransactionParamsNew, 'memos' | 'signers'>
+  storedObject: AnyBaseTransactionParamsNew
 ): BaseTransactionParamsNew => {
   const result: Partial<BaseTransactionParamsNew> = {};
 
   const addParam = <T extends keyof BaseTransactionParamsNew>(
     key: T,
-    value: BaseTransactionParamsNew[T] | null
+    value: BaseTransactionParamsNew[T]
   ) => {
     if (value !== null && value !== undefined) {
       result[key] = value;
@@ -77,7 +90,7 @@ export const parseBaseParamsFromStoredData = (
     'lastLedgerSequence' in storedObject ? Number(storedObject.lastLedgerSequence) : undefined
   );
   addParam('memos', 'memos' in storedObject ? parseMemos(storedObject.memos) : undefined);
-  addParam('networkID', 'networkID' in storedObject ? storedObject.networkID : undefined);
+  addParam('networkID', 'networkID' in storedObject ? Number(storedObject.networkID) : undefined);
   addParam('signers', 'signers' in storedObject ? parseSigners(storedObject.signers) : undefined);
   addParam('sourceTag', 'sourceTag' in storedObject ? Number(storedObject.sourceTag) : undefined);
   addParam(
@@ -141,7 +154,7 @@ export const parseBaseParamsFromURLParams = (urlParams: URLSearchParams): BaseTr
   };
 };
 
-export const getBaseFromParams = (params: Partial<BaseTransactionParams>) => {
+export const getBaseFromParams = (params: AnyBaseTransactionParamsNew) => {
   return {
     fee: params.fee || undefined,
     sequence: params.sequence || undefined,

diff --git a/packages/extension/src/utils/parseParams.ts b/packages/extension/src/utils/parseParams.ts
@@ -135,13 +135,15 @@ export const parseLimitAmount = (
   return null;
 };
 
-export const parseMemos = (input: Memo[] | string | undefined): Memo[] | undefined => {
+export const parseMemos = (
+  input: Memo[] | Record<string, unknown>[] | unknown[] | string | undefined
+): Memo[] | undefined => {
   if (!input) {
     return;
   }
 
   if (typeof input === 'object' && Array.isArray(input)) {
-    return input;
+    return input as Memo[];
   }
 
   // For API version < 3.6
@@ -158,13 +160,15 @@ export const parseMemos = (input: Memo[] | string | undefined): Memo[] | undefin
   return;
 };
 
-export const parseSigners = (input: Signer[] | string | undefined): Signer[] | undefined => {
+export const parseSigners = (
+  input: Signer[] | Record<string, unknown>[] | unknown[] | string | undefined
+): Signer[] | undefined => {
   if (!input) {
     return;
   }
 
   if (typeof input === 'object' && Array.isArray(input)) {
-    return input;
+    return input as Signer[];
   }
 
   // For API version < 3.6