Move capacity overflow panic to own cold function #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 30, 2024
[DO NOT MERGE] Perf run for ThinVec capacity overflow outlining Testing out the performance difference of Gankra/thin-vec#63 r? `@ghost`
aapoalas
reviewed
Oct 10, 2024
GnomedDev
force-pushed
the
outline-capacity-overflow
branch
from
3f61c40 to
be74b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a couple instructions from
ThinVec::pushand probably other methods as previously eachexpectwas getting it's own jump tocall expect_failedwhereas with this they can all simply jump to callcapacity_overflow. This also leads to the inlining ofheader_with_capacityintoThinVec::push, which was previously an outlined call.I can't find any benchmarks in the repo to test against, but the increased inlining with a smaller method sounds like a good thing.