[Feat/67] 매칭 실패 로직 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
Eunjin3395
reviewed
Sep 3, 2024
Comment on lines
141
to
153
| const otherSocket = await getSocketIdByMemberId(io, socket.matchingTarget); | ||
|
|
||
| // 26) 매칭 FAIL API 요청 | ||
| await updateBothMatchingStatusApi(socket,"FAIL",socket.matchingTarget); | ||
|
|
||
| // 27) 상대 client에게 matching-fail emit | ||
| emitMatchingFail(otherSocket); | ||
|
|
||
| // 28) socket.target 제거 | ||
| socket.matchingTarget=null; | ||
|
|
||
| // 29) otherSocket.matchingTarget 제거 | ||
| otherSocket.matchingTarget=null; |
There was a problem hiding this comment.
이 부분이 제가 다른 기능 구현할 때도 그랬었는데,, getSocketIdByMemberId를 할 때 찯을 대상 소켓이 disconnect된 경우에는 아예 여기서 소켓을 찾지 못하더라구요..! 그래서 otherSocket에 대한 null 여부를 체크하고 그 아래 줄부터 실행해야 오류가 안났었습니다!
There was a problem hiding this comment.
헉 그렇군요!! 알겠습니다. 수정하겠습니당!
Eunjin3395
approved these changes
Sep 3, 2024
넵! 수정하겠습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개요
매칭 실패 로직 구현했습니다
🔍 변경사항
⏳ 작업 내용
📝 논의사항
26) 매칭 FAIL API 요청
27) 상대 client에게 matching-fail emit
28) socket.target 제거
29) otherSocket.matchingTarget 제거