Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/48] 회원 신고 API 구현 #60

Merged
merged 10 commits into from
Jul 10, 2024
Merged

[Feat/48] 회원 신고 API 구현 #60

merged 10 commits into from
Jul 10, 2024

Conversation

hzee97
Copy link
Contributor

@hzee97 hzee97 commented Jul 6, 2024

🚀 개요

회원 신고 API 구현.

🔍 변경사항

  • 회원 신고 관련 테이블 수정.
  • 회원 신고 API 구현.

⏳ 작업 내용

  • 회원 신고 관련 테이블 수정.
  • 회원 신고 API 구현.
  • Swagger 명세.

📝 논의사항

@hzee97 hzee97 requested a review from Eunjin3395 July 6, 2024 09:06
@hzee97 hzee97 self-assigned this Jul 6, 2024
@hzee97 hzee97 linked an issue Jul 6, 2024 that may be closed by this pull request
1 task
@NotNull
Long targetMemberId;

@NotNull
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 list가 비어있지 않을 때 검증하기 위해서 @NotNull 말고 다른 어노테이션 사용해야 할 것 같아요!

import java.util.Set;
import java.util.stream.Collectors;

/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석은 그냥 삭제 부탁드려요..!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 주석 삭제하는 편이 좋을 것 같아요!


public Report insertReport(ReportRequest.reportInsertDTO request, Long memberId){
Member member = memberRepository.findById(memberId).orElseThrow(()->new MemberHandler(ErrorStatus.MEMBER_NOT_FOUND));

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

member와 targetMember가 같은 회원인 경우 에러 처리 추가가 필요할 것 같아요

@Builder
@NoArgsConstructor
@AllArgsConstructor
public static class reportInsertResultDTO{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reportInsertResponseDTO

import java.util.Set;
import java.util.stream.Collectors;

/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 주석 삭제하는 편이 좋을 것 같아요!

@Eunjin3395 Eunjin3395 self-requested a review July 9, 2024 08:00
@rimi3226 rimi3226 merged commit abd9d67 into develop Jul 10, 2024
@rimi3226 rimi3226 deleted the feature/48 branch July 10, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feat] 회원 신고 API 구현
3 participants