[Feat/49] 차단한 회원 목록 조회 API 구현 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rimi3226
approved these changes
Jul 2, 2024
rimi3226
reviewed
Jul 2, 2024
There was a problem hiding this comment.
프로필 이미지 변수명을 profile_image, profileImg 둘 중 하나로 통일하는 것이 좋을 것 같습니다!
전 profile_image 으로 개발했습니다.
Code Convention에 변수명 관련된 규칙을 새로 정하면 좋을 것 같아요.
There was a problem hiding this comment.
앗 저는 엔티티에서도 camel case로 속성들 선언했어서 이번에도 camel case로 한거긴 한데,, 어떤걸로 통일하는게 좋을까요?
rimi3226
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
NOT_VALID, INVALID 둘 중에 어떤거 사용할지도 Code Convention 정하면 좋을 것 같아요!
전 INVALID로 개발했긴한데 둘 다 상관없습니다.
There was a problem hiding this comment.
앗 그럼 저도 INVALID로 수정하겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개요
차단한 회원 목록 조회 API 구현
🔍 변경사항
⏳ 작업 내용
📝 논의사항