[Feat/181] 매칭 found API 구현 및 우선순위 계산 API 응답값 수정 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
rimi3226
approved these changes
Aug 23, 2024
| @@ -29,7 +29,16 @@ public class MatchingController { | |||
| private final MatchingService matchingService; | |||
|
|
|||
| @PostMapping("/priority") | |||
| @Operation(summary = "우선순위 계산 및 매칭 기록을 저장하는 API 입니다.", description = "API for calculating and recording matching") | |||
| @Operation(summary = "우선순위 계산 및 매칭 기록을 저장하는 API 입니다.", description = | |||
| "API for calculating and recording matching \n\n" | |||
There was a problem hiding this comment.
이렇게 request 값 알려주는거 좋은 것 같아욥!
There was a problem hiding this comment.
감사합니다! 그런데 생각해보니 포지션 3종은 05까지 가능인데 제가 15까지로 써놨더라구요... 다음 pr 하면서 수정하겠습니다..!
| Tier tier; | ||
| Integer rank; | ||
| Integer mannerLevel; | ||
| Integer profileImg; |
There was a problem hiding this comment.
저희 프로필 이미지도 따로 저장해야할 이유가 있었나요?
There was a problem hiding this comment.
생각해보니까 매칭할 때 프로필 이미지를 보여줘야해서 필요할 것 같네요..!!!
|
고생하셨습니다!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개요
매칭 found API 구현 및 우선순위 계산 API 응답값 수정
🔍 변경사항
⏳ 작업 내용
📝 논의사항