[Refactor/161] 알림 목록 조회, 친구 목록 조회 API 수정 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hzee97
approved these changes
Aug 13, 2024
| @@ -21,21 +21,19 @@ public class NotificationRepositoryCustomImpl implements NotificationRepositoryC | |||
| private final JPAQueryFactory queryFactory; | |||
|
|
|||
| /** | |||
| * 알림 내역 조회, 커서 기반 페이징 및 type 필터링 포함 | |||
| * 알림 내역 조회, 커서 기반 페이징 포함 | |||
| * | |||
| * @param memberId | |||
| * @param type | |||
There was a problem hiding this comment.
헉 그렇네요 다음 브랜치에서 지우겠습니다!
| @@ -29,7 +29,7 @@ public class BlockService { | |||
| private final ChatCommandService chatCommandService; | |||
| private final FriendService friendService; | |||
|
|
|||
| Integer pageSize = 9; | |||
| private final static Integer PAGE_SIZE = 10; | |||
There was a problem hiding this comment.
NotificationService.java 처럼
Suggested change
| private final static Integer PAGE_SIZE = 10; | |
| private static final Integer PAGE_SIZE = 10; |
로 통일하셔도 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개요
알림 목록 조회, 친구 목록 조회 API 수정
🔍 변경사항
⏳ 작업 내용
📝 논의사항