[Feat/149] 내가 받은 매너 평가 조회 API 구현 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Eunjin3395
approved these changes
Aug 11, 2024
Comment on lines
323
to
325
| totalCount = mannerRatings.get(0).getMannerRatingKeywordList().stream() | ||
| .map(mannerRatingKeyword -> mannerRatingKeyword.getMannerKeyword().getId()) | ||
| .collect(Collectors.toList()).size(); |
There was a problem hiding this comment.
여기에서 어차피 mannerRatingKeyword 개수만 필요한 거라면, 굳이 map으로 id 변환시키지 않고 바로 list의 size만 뽑아도 될 것 같아요!
Suggested change
| totalCount = mannerRatings.get(0).getMannerRatingKeywordList().stream() | |
| .map(mannerRatingKeyword -> mannerRatingKeyword.getMannerKeyword().getId()) | |
| .collect(Collectors.toList()).size(); | |
| totalCount = mannerRatings.get(0).getMannerRatingKeywordList().size(); |
| public int updateMannerScore(Member targetMember){ | ||
|
|
||
| // 매너평가 ID 조회 | ||
| List<MannerRating> mannerRatings = mannerRatingRepository.findByToMemberId(targetMember.getId()); |
There was a problem hiding this comment.
member 엔티티가 mannerRatingList를 양방향 매핑으로 가지고 있어서, repository로 조회 안하고 그냥 member.getMannerRatingList로 매너평가 리스트를 뽑아 올 수 있을 것 같아요!
Comment on lines
332
to
336
| List<Long> positiveMannerKeywordIds = mannerRatings.stream() | ||
| .filter(MannerRating::getIsPositive) | ||
| .flatMap(mannerRating -> mannerRating.getMannerRatingKeywordList().stream()) | ||
| .map(mannerRatingKeyword -> mannerRatingKeyword.getMannerKeyword().getId()) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
여기도 mannerKeyword의 id가 특별히 필요하지 않다면,
Suggested change
| List<Long> positiveMannerKeywordIds = mannerRatings.stream() | |
| .filter(MannerRating::getIsPositive) | |
| .flatMap(mannerRating -> mannerRating.getMannerRatingKeywordList().stream()) | |
| .map(mannerRatingKeyword -> mannerRatingKeyword.getMannerKeyword().getId()) | |
| .collect(Collectors.toList()); | |
| int positiveCount = mannerRatings.stream() | |
| .filter(MannerRating::getIsPositive) | |
| .flatMap(mannerRating -> mannerRating.getMannerRatingKeywordList().stream()) | |
| .collect(Collectors.toList()) | |
| .size(); |
이렇게 수정해도 될 것 같습니다!
| } | ||
|
|
||
| // 매너점수를 산정하고 업데이트. | ||
| public int updateMannerScore(Member targetMember){ |
There was a problem hiding this comment.
이건 MannerService 내에서만 사용되는 메소드인 것 같은데, 그럼 private으로 선언하는게 좋을 것 같습니다!
| } | ||
|
|
||
| // 매너레벨 결정 | ||
| public int mannerLevel(int mannerCount){ |
| Member member = memberRepository.findById(memberId).orElseThrow(() -> new MemberHandler(ErrorStatus.MEMBER_NOT_FOUND)); | ||
|
|
||
| // 매너평가 ID 조회 | ||
| List<MannerRating> mannerRatings = mannerRatingRepository.findByToMemberId(member.getId()); |
There was a problem hiding this comment.
여기도 member.getMannerRatingList()로 가능합니다!
| } | ||
|
|
||
| Integer mannerLevel = member.getMannerLevel(); | ||
| return new MannerResponse.myMannerResponseDTO(mannerLevel, mannerKeywordDTOs); |
There was a problem hiding this comment.
여기서 builder로 DTO 생성하는 건 어떠신가요?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개요
매너점수 산정 및 매너레벨 결정, 업데이트
내가 받은 매너 평가 조회 API 구현
🔍 변경사항
⏳ 작업 내용
📝 논의사항