[Feat/139] 매너평가 조회 API 구현 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
rimi3226
approved these changes
Aug 9, 2024
Comment on lines
+38
to
+39
| @Builder | ||
| @Setter |
There was a problem hiding this comment.
Builder나 Setter 둘 중 하나만 사용해도 좋을 것 같아요! Builder만 사용하는거 어떠세요!?
Eunjin3395
approved these changes
Aug 10, 2024
Comment on lines
+275
to
+278
| List<MannerRating> mannerRatings = mannerRatingRepository.findByFromMemberIdAndToMemberId(member.getId(), targetMember.getId()); | ||
| List<MannerRating> positiveMannerRatings = mannerRatings.stream() | ||
| .filter(MannerRating::getIsPositive) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
여기서 굳이 전체 mannerRating을 조회한 다음에 stream filter로 positive인 애를 거르지 말고, repository에서 mannerRating을 조회할 때 findByFromMemberIdAndToMemberAndIsPositive ? 이런 식으로 boolean 값까지 입력 받아서 조회하는 방식은 어떤가요?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개요
매너평가 조회 API 구현
🔍 변경사항
⏳ 작업 내용
📝 논의사항