[Feat/115] 게시판 글 목록 조회 필터 기능 구현 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
rimi3226
approved these changes
Aug 8, 2024
| @@ -68,6 +68,7 @@ public static class boardListResponseDTO{ | |||
| List<Long> championList; | |||
| Double winRate; | |||
| LocalDateTime createdAt; | |||
| Boolean voice; | |||
There was a problem hiding this comment.
회원이랑 매칭에서 마이크 유무를 mike로 사용중인데 혹시 voice 대신에 mike를 사용해주실 수 있으신가요..?ㅠㅠ
Eunjin3395
approved these changes
Aug 8, 2024
Comment on lines
+122
to
+125
| if (mainPosition != null && mainPosition == 0) { | ||
| // 전체 포지션 선택 시 필터링에서 제외 | ||
| mainPosition = null; | ||
| } |
There was a problem hiding this comment.
어차피 전체 포지션 선택 시 필터링 조건이 없는거라면 mainPosition을 0으로 입력받아야하는 이유가 있을까요?
There was a problem hiding this comment.
포지션 선택을 안하거나 전체 포지션(*)을 선택할 경우 필터링하지 않고 전체 목록이 보이게 구현하였습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개요
게시판 글 목록 조회 필터 기능 구현
🔍 변경사항
⏳ 작업 내용
📝 논의사항