Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/110] 친구 요청 등록 API 구현 #119

Merged
merged 9 commits into from
Aug 8, 2024
Merged

[Feat/110] 친구 요청 등록 API 구현 #119

merged 9 commits into from
Aug 8, 2024

Conversation

Eunjin3395
Copy link
Member

@Eunjin3395 Eunjin3395 commented Aug 7, 2024

🚀 개요

친구 요청 등록 API 구현 및 기존 코드 리팩토링

🔍 변경사항

  • 기존에 MemberController에서 관리하던 api를 BlockController, FriendController로 분리
  • 친구 요청 등록 API 구현
  • domain 패키지 내 friend 패키지 추가
  • FriendRequests 엔티티에 status 칼럼 추가
  • MemberUtils 클래스 추가: isBlocked, checkBlind 메소드 공용 클래스로 분리
  • 회원 차단 API에 본인 차단 시도 에러 처리 추가

⏳ 작업 내용

  • 친구 요청 등록 API 구현
  • FriendRequests 엔티티에 status 칼럼 추가
  • MemberUtils 공용 클래스 추가
  • 패키지 구조 변경
  • 회원 차단 API 에러 처리 추가

📝 논의사항

@Eunjin3395 Eunjin3395 requested review from rimi3226 and hzee97 August 7, 2024 14:24
@Eunjin3395 Eunjin3395 self-assigned this Aug 7, 2024
@Eunjin3395 Eunjin3395 linked an issue Aug 7, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@hzee97 hzee97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@@ -25,6 +29,7 @@ public static class blockListDTO {
@NoArgsConstructor
@AllArgsConstructor
public static class blockedMemberDTO {

Long memberId;
String profileImg;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

profileImage Integer로 변경됐습니다! 혹시 수정해주실 수 있으신가요ㅠㅠ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 수정하겠습니다!

@@ -99,4 +104,5 @@ public static class friendInfoDTO {
String memberProfileImg;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앞 리뷰와 동일하게 profileImage String -> Integer로 자료형 변경됐습니다!

@Eunjin3395 Eunjin3395 merged commit 50f34c2 into develop Aug 8, 2024
@Eunjin3395 Eunjin3395 deleted the feat/110 branch August 8, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feat] 친구 요청 전송 API 구현
3 participants