[Fix/98] 회원가입 로직 수정 #106
Merged
[Fix/98] 회원가입 로직 수정 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eunjin3395
approved these changes
Aug 2, 2024
| @@ -32,8 +33,10 @@ public void setMember(Member member) { | |||
| this.member.getMemberChampionList().remove(this); | |||
| } | |||
| this.member = member; | |||
| if (this.member.getMemberChampionList() == null) { | |||
There was a problem hiding this comment.
혹시 여기에서 이 조건을 추가하신 이유가 있으신가요?
@OneToMany(mappedBy = "member", cascade = CascadeType.ALL) private List<MemberChampion> memberChampionList = new ArrayList<>();
member 엔티티에서 이렇게 초기화를 해 주어서 저는 memberChampionList가 null인 경우가 없을 거라고 생각했었는데 혹시 이 조건+코드가 없으면 뭔가 오류가 나는건지 궁금합니다..!
There was a problem hiding this comment.
네ㅠㅠ 이상하게 @onetomany를 했음에도 불구하고 이런 에러가 발생하더라구요..
Cannot invoke "java.util.List.add(Object)" because the return value of "com.gamegoo.domain.Member.getMemberChampionList()" is null
그래서 추가했습니다!
There was a problem hiding this comment.
헉 그렇군요...... ㅠㅠㅠㅠ 왜 그런건지 제가 나중에 따로 찾아보겠습니다.. 그럼 이대로 머지해주시면 될 것 같아요 !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개요
회원가입 로직 수정
🔍 변경사항
⏳ 작업 내용
📝 논의사항