Merge pull request #198 from Gamegoo-repo/refactor/173

[Refactor/173] chatCommandService 메소드 테스트 코드 작성
Gamegoo-repo · Sep 1, 2024 · 2e3fd18 · 2e3fd18
2 parents 67b8469 + 1daa409
commit 2e3fd18
Show file tree

Hide file tree

Showing 6 changed files with 2,084 additions and 114 deletions.
diff --git a/src/main/java/com/gamegoo/dto/chat/ChatResponse.java b/src/main/java/com/gamegoo/dto/chat/ChatResponse.java
@@ -50,8 +50,8 @@ public static class ChatroomEnterDTO {
         Long memberId;
         String gameName;
         Integer memberProfileImg;
-        boolean friend;
-        boolean blocked;
+        Boolean friend;
+        Boolean blocked;
         Long friendRequestMemberId;
         SystemFlagDTO system;
         ChatMessageListDTO chatMessageList;

diff --git a/src/main/java/com/gamegoo/service/chat/ChatCommandService.java b/src/main/java/com/gamegoo/service/chat/ChatCommandService.java
@@ -508,7 +508,7 @@ private void createAndSaveMemberChatroom(Member member, Chatroom chatroom,
      */
     private Chat createAndSaveSystemChat(Chatroom chatroom, Member toMember,
         String content, Board sourceBoard) {
-        Member systemMember = profileService.findMember(0L);
+        Member systemMember = profileService.findSystemMember();
 
         Chat systemChat = Chat.builder()
             .contents(content)

diff --git a/src/main/java/com/gamegoo/service/member/ProfileService.java b/src/main/java/com/gamegoo/service/member/ProfileService.java
@@ -146,6 +146,12 @@ public Member findMember(Long memberId) {
             .orElseThrow(() -> new MemberHandler(ErrorStatus.MEMBER_NOT_FOUND));
     }
 
+    @Transactional(readOnly = true)
+    public Member findSystemMember() {
+        return memberRepository.findById(0L)
+            .orElseThrow(() -> new MemberHandler(ErrorStatus.MEMBER_NOT_FOUND));
+    }
+
     /**
      * 특정 회원의 유저프로필 조회, 차단 여부, 친구 여부, 친구 요청 상태 포함
      *

diff --git a/src/test/java/com/gamegoo/chat/ChatServiceTest.java b/src/test/java/com/gamegoo/chat/ChatServiceTest.java