Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat/154] Security 설정 및 Jwt @AuthMember 연동 #164

Merged
merged 5 commits into from
Jan 17, 2025
Merged

[Feat/154] Security 설정 및 Jwt @AuthMember 연동 #164

merged 5 commits into from
Jan 17, 2025

Conversation

rimi3226
Copy link
Contributor

🚀 개요

시큐리티 설정 추가

⏳ 작업 상세 내용

  • 시큐리티 설정 추가
  • @AuthMember와 연동
  • JWT Filter 개발

📝 더 꼼꼼히 봐야할 부분

  • 현재 role을 string으로 받고있는데 roleType을 따로 enum으로 지정하는게 좋을까요? 개인적으로는 관리자 계정을 DB에 안넣어도 되니까 그냥 String으로 받아와도 괜찮을 것 같기도하고 잘 모르겠네요..
  • API 정상 작동하는거 swagger로 테스트 완료했습니당! 테스트코드 수정 부탁드릴게욤..ㅜㅜ

🔍 반드시 참고해야하는 변경 사항

  • 없을 경우 체크

@rimi3226 rimi3226 self-assigned this Jan 15, 2025
@rimi3226 rimi3226 linked an issue Jan 15, 2025 that may be closed by this pull request
✨ [Feat] Security 설정 #154
Closed
4 tasks
Eunjin3395
Eunjin3395 requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@Eunjin3395 Eunjin3395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 JwtAuthentication이 발생했을 때 ApiResponse를 만들어서 응답하는 부분이 제대로 안되어 있습니다 ㅠㅠ 다른 filter들도 제대로 동작하는지 다 테스트가 필요할 것 같습니다.. 혹시 효림님은 로컬에서 정상 작동 되시는건가요..?

src/main/java/com/gamegoo/gamegoo_v2/core/config/SecurityConfig.java Outdated Show resolved Hide resolved
...ain/java/com/gamegoo/gamegoo_v2/account/auth/security/JwtAuthenticationExceptionHandler.java Outdated Show resolved Hide resolved
src/main/java/com/gamegoo/gamegoo_v2/account/auth/security/CustomUserDetails.java Outdated Show resolved Hide resolved
Eunjin3395
Eunjin3395 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@Eunjin3395 Eunjin3395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@Eunjin3395 Eunjin3395 merged commit f082226 into develop Jan 17, 2025
1 check failed
@rimi3226 rimi3226 deleted the feat/154 branch February 5, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eunjin3395 Eunjin3395 Eunjin3395 approved these changes

@coldmans coldmans Awaiting requested review from coldmans coldmans is a code owner

Assignees

@rimi3226 rimi3226

@Eunjin3395 Eunjin3395

Labels
✨ feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [Feat] Security 설정
2 participants
@rimi3226 @Eunjin3395