Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conditional shader compilation #1433

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add conditional shader compilation #1433

wants to merge 1 commit into from

Conversation

tomas7770
Copy link
Contributor

@tomas7770 tomas7770 commented Jan 26, 2025 •
edited
Loading

Description

Adds the ability to configure compile-time shader parameters using #define macros. This allows changing e.g. the number of CSM splits in deferred shading, textures drawn to in the G-buffer rasterizer (to disable/enable the render picker).

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@tomas7770 tomas7770 linked an issue Jan 26, 2025 that may be closed by this pull request
Add conditional shader compilation #1406
Open
@github-actions github-actions bot added A-Engine B-Rendering P-Normal This issue isn't a big priority, but it would still be nice to have it closed soon labels Jan 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://GameDevTecnico.github.io/cubos/preview/pr-1433/

Built to branch gh-pages at 2025-01-30 20:08 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@tomas7770 tomas7770 marked this pull request as ready for review January 26, 2025 16:28
@tomas7770 tomas7770 requested review from RiscadoA and a team as code owners January 26, 2025 16:28
@tomas7770 tomas7770 requested review from Docas95, mkuritsu and SrGesus and removed request for a team and SrGesus January 26, 2025 16:28
@cubos-bot Cubos Bot
Copy link

cubos-bot bot commented Jan 27, 2025

@RiscadoA will only be able to review this PR in 5 days.

mkuritsu
mkuritsu requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@mkuritsu mkuritsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM just pointing some changes that could be made/discussed

engine/src/render/shader/shader.cpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/render/shader/shader.hpp Outdated Show resolved Hide resolved
engine/src/render/shader/shader_builder.cpp Outdated Show resolved Hide resolved
@tomas7770 tomas7770 force-pushed the 1406-add-conditional-shader-compilation branch from 245e738 to 4153b2b Compare January 30, 2025 20:06
@mkuritsu mkuritsu self-requested a review January 31, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuritsu mkuritsu mkuritsu approved these changes

@Docas95 Docas95 Docas95 approved these changes

@RiscadoA RiscadoA Awaiting requested review from RiscadoA RiscadoA is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
A-Engine B-Rendering P-Normal This issue isn't a big priority, but it would still be nice to have it closed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add conditional shader compilation
3 participants
@tomas7770 @Docas95 @mkuritsu