-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rendering): Add Shadow Normal Offset Bias in the deferred shading #1370
feat(rendering): Add Shadow Normal Offset Bias in the deferred shading #1370
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a small change in the variable types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just tested some of the demos from the cubos-demo repo and noticed significant improvements!
Also, don't forget to update the changelog! |
22b1f94
to
7341b8d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1370 +/- ##
==========================================
- Coverage 54.23% 54.22% -0.01%
==========================================
Files 438 438
Lines 25338 25341 +3
Branches 2347 2347
==========================================
Hits 13742 13742
- Misses 11596 11599 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
7341b8d
to
09ba33f
Compare
Description
I added the Shadow Normal Offset Bias to the deferred shading and gave the user the option to use or not use this bias.
Checklist