Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump submodules to bring in changes from GaloisInc/crucible#1225 #2078

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

RyanGlScott
Copy link
Contributor

This bumps the crucible submodule to bring in the changes from GaloisInc/crucible#1225, which fixes GaloisInc/crucible#1224 on the SAW side. This also requires bumping the cryptol, macaw, and what4 submodules in order to construct a consistent build plan with the latest crucible.

This bumps the `crucible` submodule to bring in the changes from
GaloisInc/crucible#1225, which fixes GaloisInc/crucible#1224 on the SAW side.
This also requires bumping the `cryptol`, `macaw`, and `what4` submodules in
order to construct a consistent build plan with the latest `crucible`.
@RyanGlScott RyanGlScott added the PR: submodule bump Pull requests that include a submodule bump label Jul 18, 2024
@sauclovian-g
Copy link
Contributor

This ends up still some six weeks behind in cryptol, and while there's something to be said for taking the minimum change required (especially in the context of syncing with another update) ISTM that we probably at least want the py-certifi dependabot change in cryptol sooner rather than later. So if you don't want to include that much right now I'd suggest another branch to pull it in...

@RyanGlScott
Copy link
Contributor Author

Right, I chose the latest commit I could without needing to pull in the changes from GaloisInc/cryptol#1664, which would require SAW to adapt to API changes on the cryptol side. I'll update SAW to the latest cryptol submodule commit in a separate PR.

@RyanGlScott RyanGlScott merged commit 125f9a6 into master Jul 19, 2024
34 checks passed
@RyanGlScott RyanGlScott deleted the crucible-T1225-ArrayToPointer-CastKind branch July 19, 2024 13:09
@RyanGlScott
Copy link
Contributor Author

I'll update SAW to the latest cryptol submodule commit in a separate PR.

See #2079.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: submodule bump Pull requests that include a submodule bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crucible-mir fails to parse MIR JSON that casts array reference to pointer
2 participants