Changes to X86_64 verification. #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
approved these changes
Jan 17, 2024
src/SAWScript/Crucible/LLVM/X86.hs
Outdated
| C.FinishedResult _ pr -> do | ||
| gp <- getGlobalPair opts pr | ||
| mem' <- maybe | ||
| (fail "internal error: LLVM Memory global not found") |
There was a problem hiding this comment.
Perhaps this should panic instead of failing? I can't foresee the call to lookupGlobal mvar (gp ^. gpGlobals) failing unless the code itself is wrong.
src/SAWScript/Crucible/LLVM/X86.hs
Outdated
| mem' <- maybe | ||
| (fail "internal error: LLVM Memory global not found") | ||
| return | ||
| (C.lookupGlobal mvar $ gp ^. C.gpGlobals) |
There was a problem hiding this comment.
There are at least two calls to lookupGlobal mvar (gp ^. gpGlobals) in this file (there's another on line 578) that in turn validate that it returns a Just value. It might be worth factoring this out into a little helper function.
Comment on lines
+1697
to
+1702
| getPoststateObligations :: | ||
| Crucible.IsSymBackend Sym bak => | ||
| SharedContext -> | ||
| bak -> | ||
| IORef MetadataMap -> | ||
| IO [(String, MS.ConditionMetadata, Term)] |
There was a problem hiding this comment.
It would be helpful to include some Haddocks stating what this function computes. For instance, what is the String in the return type? (It's hard to know without looking at the implementation.)
kquick
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code to use
getPoststateObligationsin bothBuiltins.hsandX86.hs. Fail in the case ofAbortedResultinX86.hs(like inBuiltins.hs). Some more changes, I think to fix a bug, but I don't remember.