mir_fresh_expanded_value
#1955
Merged
mir_fresh_expanded_value
#1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
RyanGlScott
force-pushed
the
T1859-mir_fresh_expanded_value
branch
from
a87e458 to
3899676
Compare
spernsteiner
approved these changes
Nov 7, 2023
RyanGlScott
force-pushed
the
T1859-mir_fresh_expanded_value
branch
from
3899676 to
7e2802e
Compare
RyanGlScott
added
the
PR: ready to merge
This adds a `mir_fresh_expanded_value` command, which creates a MIR value populated entirely by fresh symbolic variables. For compound types such as structs or arrays, this will explicitly set each field or element to contain a fresh symbolic variable. This is heavily inspired by the `llvm_fresh_expanded_val` command in the LLVM backend. This command will be important for the MIR user story going forward, as we will impose an requirement that all mutable allocations in an override must be explicitly set in the override's postconditions. The `mir_fresh_expanded_value` command provides a convenient way to quickly generate values to set in the postconditions. At present, `mir_fresh_expanded_value` comes with the limitation that it does not support reference types. This is not an inherent limitation, but it is one that will require some additional work to lift. In particular, we will likely need something like a `mir_fresh_ref` command (similar to LLVM's `llvm_fresh_pointer` command) to make this work. We leave the task of implementing `mir_fresh_ref` to a later patch. This checks off one box in #1859.
RyanGlScott
force-pushed
the
T1859-mir_fresh_expanded_value
branch
from
7e2802e to
5f93332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
mir_fresh_expanded_valuecommand, which creates a MIR value populated entirely by fresh symbolic variables. For compound types such as structs or arrays, this will explicitly set each field or element to contain a fresh symbolic variable. This is heavily inspired by thellvm_fresh_expanded_valcommand in the LLVM backend.This command will be important for the MIR user story going forward, as we will impose an requirement that all mutable allocations in an override must be explicitly set in the override's postconditions. The
mir_fresh_expanded_valuecommand provides a convenient way to quickly generate values to set in the postconditions.At present,
mir_fresh_expanded_valuecomes with the limitation that it does not support reference types. This is not an inherent limitation, but it is one that will require some additional work to lift. In particular, we will likely need something like amir_fresh_refcommand (similar to LLVM'sllvm_fresh_pointercommand) to make this work. We leave the task of implementingmir_fresh_refto a later patch.This checks off one box in #1859.