Support building with GHC 9.8 #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have managed to call `tail` here on empty lists before (see #1000), which leads to confusing error messages. Let's replace this with explicit pattern-matching plus a call to `panic` in the empty list case to make it more obvious where the error comes from. Moreover, doing this fixes a `-Wx-partial` warning on GHC 9.8, which is also nice.
`pkg-config` is needed for the Haskell `zlib` library to locate the system's `zlib` installation.
RyanGlScott
requested review from
kquick,
langston-barrett and
mccleeary-galois
langston-barrett
approved these changes
Aug 2, 2024
kquick
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a variety of fixes needed to build the libraries in the
cruciblerepo with GHC 9.8:jvm-parsersubmodule to bring in the changes from Fix-Wx-partial warningsdiscovered by GHC 9.8 jvm-parser#12.baseandth-abstractionwere raised to allow building with GHC 9.8.-Wx-partialwarning to-Wall, which warns on uses of the partialheadandtailfunctions. I have made an effort to remove uses of these functions where possible. Where this is not possible, I have rewritten uses ofheadandtailinto pattern matches with explicitpanics in the partial cases.