llvm: Refactor and document binding functions #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binding functions (whether they be translated CFGs or overrides) in the LLVM memory model is a bit more complex than in other frontends. We had organically grown a number of helpers that take care of various parts of this process, without actually documenting what needs to happen for everything to work as expected. This commit collects those helpers into a single module, with a top-level comment that outlines the whole process. Along the way, it removes some superfluous helpers (`bindLLVMFunPtr`) and introduces some new ones (`bindLLVMCFG`).
RyanGlScott
reviewed
Apr 26, 2024
RyanGlScott
approved these changes
Apr 26, 2024
langston-barrett
force-pushed
the
lb/llvm-bind-fns
branch
from
fa0ff61 to
50dcfad
Compare
RyanGlScott
added a commit
that referenced
this pull request
May 14, 2024
PR #1198 moved `bindLLVMFunPtr` to `Lang.Crucible.LLVM.Functions`, but it did not export it publicly. This function is used by SAW, so it would be nice to continue to offer it as part of the public API.
Merged
RyanGlScott
added a commit
that referenced
this pull request
May 14, 2024
PR #1198 moved `bindLLVMFunPtr` to `Lang.Crucible.LLVM.Functions`, but it did not export it publicly. This function is used by SAW, so it would be nice to continue to offer it as part of the public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding functions (whether they be translated CFGs or overrides) in the LLVM memory model is a bit more complex than in other frontends. We had organically grown a number of helpers that take care of various parts of this process, without actually documenting what needs to happen for everything to work as expected. This PR collects those helpers into a single module, with a top-level comment that outlines the whole process.
Along the way, it removes some superfluous helpers (
bindLLVMFunPtr) and introduces some new ones (bindLLVMCFG).