Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement byte-to-char casts for crucible-mir. #1191

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

sauclovian-g
Copy link
Contributor

No description provided.

@RyanGlScott
Copy link
Contributor

Thanks, @sauclovian-g! I can believe that this fixes the issue, but I would feel better if we added a regression test alongside it. Can you add this test case to crux-mir's test suite? I'm not too bothered about the exact location where we put the test—somewhere in test/conc_eval/num would work, for instance.

@RyanGlScott
Copy link
Contributor

@sauclovian-g, do you plan on finishing this?

@sauclovian-g
Copy link
Contributor Author

Yes, we need it for FV, just disorganized/behind on everything :-|

@sauclovian-g sauclovian-g requested a review from RyanGlScott July 31, 2024 23:16
@sauclovian-g
Copy link
Contributor Author

This should be ready to go now.

(I think I should rebase it on master before merging, and probably squash the two commits together too, but probably you should look at it first)

Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this one over the finish line!

@sauclovian-g
Copy link
Contributor Author

I rebased it on master and squashed the commits together. Since it's small and isolated this is pretty harmless, and it's been sitting around for a while.

@sauclovian-g sauclovian-g merged commit 5b4d945 into master Aug 1, 2024
32 checks passed
@sauclovian-g sauclovian-g deleted the dholland-cast branch August 1, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants