crucible-mir: Use correct identifiers for TransCustom intrinsics
#1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spernsteiner
approved these changes
Dec 13, 2023
This uses the correct identifiers for intrinsics, such as
`core::intrinsics::{extern}::rotate_left`. Previously, the `"{extern}"` portion
was written as `""` due to an oversight.
Fixes #1129.
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 10, 2024
This bumps the `crucible` submodule to a commit that brings in the changes from GaloisInc/crucible#1158. Among other things, this adds an override for the Rust `rotate_left` function, which is crucial to making the SAW Rust tutorial work. Fixes #2003.
RyanGlScott
added a commit
that referenced
this pull request
Feb 1, 2024
RyanGlScott
added a commit
that referenced
this pull request
Feb 6, 2024
(cherry picked from commit bc05b99)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the correct identifiers for intrinsics, such as
core::intrinsics::{extern}::rotate_left. Previously, the"{extern}"portion was written as""due to an oversight.Fixes #1129.