Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crux-mir: Avoid pointer arithmetic in vec::IntoIter #1157

Merged
merged 2 commits into from
Dec 20, 2023
Merged

crux-mir: Avoid pointer arithmetic in vec::IntoIter #1157

merged 2 commits into from
Dec 20, 2023

Conversation

qsctr
Copy link
Contributor

@qsctr qsctr commented Dec 12, 2023

We do the same thing as 69e92cb for vec::IntoIter.

Fixes #1144.

@qsctr qsctr added crucible crux MIR Issues relating to Rust/MIR support labels Dec 12, 2023
@qsctr
Copy link
Contributor Author

qsctr commented Dec 12, 2023

@RyanGlScott Is there a place to put the test case? I saw there is crux-mir/test/symb_eval/alloc but the tests in there seem to be for allocate from the crucible crate and not the standard Rust alloc.

@qsctr qsctr self-assigned this Dec 12, 2023
@RyanGlScott
Copy link
Contributor

Thanks, @qsctr!

Is there a place to put the test case? I saw there is crux-mir/test/symb_eval/alloc but the tests in there seem to be for allocate from the crucible crate and not the standard Rust alloc.

Indeed, all of the test cases in the symb_eval subdirectly rely on symbolic branching in some way. The test case in #1144 (comment), however, is entirely concrete. For that reason, I'd favor placing the test case under crux-mir/tests/conc_eval. I'm not picky about which conc_eval subdirectory to use—something like conc_eval/vec should be fine.

@qsctr qsctr marked this pull request as ready for review December 20, 2023 02:21
@qsctr qsctr merged commit dba7b1b into master Dec 20, 2023
31 checks passed
@qsctr qsctr deleted the T1144 branch December 20, 2023 23:35
RyanGlScott added a commit that referenced this pull request Feb 1, 2024
RyanGlScott added a commit that referenced this pull request Feb 6, 2024
(cherry picked from commit e1fc9f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crucible crux MIR Issues relating to Rust/MIR support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crux_mir: Iterating over 0-length Vec fails with tried to subtract pointers into different arrays
2 participants