crucible-mir: Handle repr(transparent) enums appropriately
#1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two places in the code where `repr(transparent)` enums ought to have been treated specially, but weren't: * In the `ConstEnum` case for `transConstVal`. * In the `AdtAg` case of `transRval`, which handles enum variant assignments. I've now added the appropriate special-casing and added a `conc_eval/enum/repr_transparent.rs` test case in the `crux-mir` test suite to ensure that it works as expected. Fixes #1140.
spernsteiner
approved these changes
Dec 7, 2023
RyanGlScott
added a commit
that referenced
this pull request
Feb 1, 2024
RyanGlScott
added a commit
that referenced
this pull request
Feb 6, 2024
(cherry picked from commit 5fb4da5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two places in the code where
repr(transparent)enums ought to have been treated specially, but weren't:ConstEnumcase fortransConstVal.AdtAgcase oftransRval, which handles enum variant assignments.I've now added the appropriate special-casing and added a
conc_eval/enum/repr_transparent.rstest case in thecrux-mirtest suite to ensure that it works as expected.Fixes #1140.