crucible-syntax: Separate interface and implementation of parsing monad #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
approved these changes
Nov 15, 2023
Previously, helpers for parsing with the abstract `MonadSyntax` interface were intermingled with utilities for dealing with the concrete `SyntaxParse` implementation. This patch splits them up, with the implementation depending on (and implementing) the interface.
langston-barrett
force-pushed
the
lb/crucible-syntax-refactor
branch
from
4209fc7 to
f3ce0bd
Compare
kquick
reviewed
Nov 15, 2023
|
@kquick Thanks for taking a look! The code you commented on wasn't introduced in this PR, just moved between modules. I've deferred adding documentation to an issue. I can't say I'm an expert on the intent of these various pieces, I didn't write them and am trying to reverse-engineer their intent myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, helpers for parsing with the abstract
MonadSyntaxinterface were intermingled with utilities for dealing with the concreteSyntaxParseimplementation. This patch splits them up, with the implementation depending on (and implementing) the interface.