Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrizer memory card enhancement #3902

Merged
merged 15 commits into from
Feb 6, 2025
Merged

Parametrizer memory card enhancement #3902

merged 15 commits into from
Feb 6, 2025

Conversation

FrostyFire1
Copy link
Contributor

The parametrizer memory card has a few issues:

  • You can't be sure if it even worked when you use it (nothing happens other than the right click animation)
  • The tooltip looks like this:
    image
    This PR makes the following changes to the card:
  • Adds more information to the tooltip and makes the configuration readable:
    image
  • Prevents pasting configuration from a different multiblock
  • Prevents pasting if the card is empty
  • Makes the card send a message when it copies, pastes or fails to paste the configuration:
2025-02-06.17-04-04.mp4

Closes #18963

FrostyFire1 and others added 13 commits February 4, 2025 03:14
@FrostyFire1
Fix UV Pump and Field Generator
c208b3d
@FrostyFire1
Merge branch 'GTNewHorizons:master' into master
0aae49d
@FrostyFire1
Fix primary winding not affecting max output voltage
3f5c065
@FrostyFire1
Paremetrizer card enhancements
72c5c5f 
Chat messages for: copying, pasting, controller mismatch
Don't paste config if controller mismatch
Setting names instead of hatch IDs
Controller name and coords saved to card
@FrostyFire1
remove check for "unused", replace metaTE with controller
0d108b0
@FrostyFire1
redo mismatched controller check, don't make nbt keys dynamically
7cc869a
@FrostyFire1
fix hasIdenticalParameterList looking at the wrong nbt data
0a9d809
@FrostyFire1
Merge branch 'GTNewHorizons:master' into parametrizer-enhancement
0af222c
@FrostyFire1
spotless
5635f78
@FrostyFire1
Merge remote-tracking branch 'origin/parametrizer-enhancement' into p…
be96ee1 
…arametrizer-enhancement
@FrostyFire1
stupid tesla fix coming into my parametrizer pr
f859a61
@FrostyFire1
comment about tesla
8470249
@FrostyFire1
add no configuration fail
9029662
@StaffiX StaffiX added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Feb 6, 2025
@serenibyss serenibyss enabled auto-merge (squash) February 6, 2025 20:06
@serenibyss serenibyss merged commit e722956 into GTNewHorizons:master Feb 6, 2025
5 checks passed
@FrostyFire1 FrostyFire1 deleted the parametrizer-enhancement branch February 6, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenibyss serenibyss serenibyss approved these changes

Assignees
No one assigned
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show Stored Parameters on Parametrizer Memory Card Tooltip
3 participants
@FrostyFire1 @serenibyss @StaffiX