Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Constraint Target For inventory-item-has-vendor-name #1099

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Jan 15, 2025

Committer Notes

Purpose

This PR aims to adjust the target for the inventory-item-has-vendor-name constraint per #1097.

Changes

  • Adjusted the constraint to only target inventory-items/components of type "hardware" or "software".

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you set "Allow edits and access to secrets by maintainers"?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Have you added an explanation of what your changes do and why you'd like us to include them?
    - [ ] If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.? Not applicable.
  • If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Jan 15, 2025
@Gabeblis Gabeblis requested a review from a team as a code owner January 15, 2025 16:59
@Gabeblis Gabeblis linked an issue Jan 15, 2025 that may be closed by this pull request
14 tasks
@Gabeblis Gabeblis force-pushed the constraints/issue-1097 branch from 6c80d54 to 6fd9c91 Compare January 15, 2025 17:05
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@aj-stein-gsa aj-stein-gsa merged commit 63d3424 into GSA:develop Jan 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce inventory-item-has-vendor-name only for software and hardware
3 participants