Ckan 2.10 #255
Merged
Ckan 2.10 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ckanext.spatial.plugin] The spatial search backend has been renamed to , please update your configuration
Apparently, the format of extras changed... We don't know why exactly, but it had to be from upstream extensions and/or core... this may or may not be acceptable... needs review..
tag lists were unordered and could not be compared, so sort them..
- before_search --> before_dataset_search - before_index --> before_dataset_index - after_show --> after_dataset_show - Reference: ckan/ckan#6501
THIS WAS THE BANE OF MY EXISTENCE FOR FOOOUUURRRR DAYS... But yeah, this changed upstream and we need to reference the new version of solr_backend. I made a similar change in another repo or an earlier commit
until it is merged into main and released on pypi
It is necessary for s3 tests
Something broke after this commit, hopefully this commit is a working one too..
I don't know where this is supposed to redirect to.. but this seemed the most relevant?
Returning when json is none breaks some other number-based location inputs
Don't give json a reason to parse null into none.. and let the get_geo_from_string run even if json fails
Change the way we capture word-based locations
default to an empty str if nothing else works
FuhuXia
approved these changes
Jul 12, 2023
btylerburton
approved these changes
Jul 12, 2023
Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| ARG CKAN_VERSION=2.9.5 | |||
| ARG CKAN_VERSION=2.10 | |||
There was a problem hiding this comment.
should value be 2.10.1?
Makefile
Outdated
| @@ -1,4 +1,4 @@ | |||
| CKAN_VERSION ?= 2.9.7 | |||
| CKAN_VERSION ?= 2.10 | |||
There was a problem hiding this comment.
should value be 2.10.1?
|
@btylerburton we should change the required tests, because apparently the required test is for 2.9.7 but now it should be 2.10.1... |
|
yeah, i can update that. |
|
i'm going to update those CKAN version references to |
|
CKAN 2.10 is CKAN 2.10.1. No need to limit ourselves to #.#.1 unless we have a reason to pin to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
Changes:
2.9and2.102.10solrtosolr-bboxforsearch_backendstrcontext['schema']['id']andcontext['schema']['tags']['name']before_actionbefore_????deprecated and replaced bybefore_dataset_????SysadminWithTokeninstead ofSysadminsinceapikeyhas been deprecated in favor oftokenpyprojfrom2.6.1to3.4.1based on spatial requirementsgeojsonfrom2.5.0to3.0.1based on spatial requirementsTODO:
license_listnot working data.gov#4293export_csvtest?Random notes for the future:
Random important references: