Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tts 735 736 #741

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Feature/tts 735 736 #741

merged 5 commits into from
Jan 8, 2025

Conversation

ximekilgsa
Copy link
Contributor

  • Adds site scanning to products
  • Updates CPARS logo

@ximekilgsa ximekilgsa requested review from a team as code owners January 8, 2025 17:51
@wesley-dean-gsa
Copy link
Contributor

Preview This Branch

You may view the preview version of the site with the following URL:

https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/

It may take a minute before changes in this Pull Request (PR) show up ⏱️

@wesley-dean-gsa
Copy link
Contributor

wesley-dean-gsa commented Jan 8, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.92% (-0.99% 🔻)
230/307
🟡 Branches 75.8% 166/219
🟢 Functions
80.65% (-2.69% 🔻)
25/31
🟡 Lines
74.92% (-0.99% 🔻)
230/307
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 global.js
91.89% (-0.84% 🔻)
91.74%
88.89% (-5.23% 🔻)
91.89% (-0.84% 🔻)
🟡 positions.js
65.31% (-1.02% 🔻)
60% 69.23%
65.31% (-1.02% 🔻)

Test suite run failed

Failed tests: 2/83. Failed suites: 1/22.
  ● imageShortcode › should generate an img tag with the correct src and alt, using default class

    TypeError: imageShortcode is not a function

      12 |
      13 |     // Call imageShortcode and capture the result
    > 14 |     const result = await imageShortcode("test-image.jpg", "Test Image");
         |                          ^
      15 |
      16 |     // Ensure the result matches the expected HTML string
      17 |     expect(result).toBe(mockResult); // Check if the result matches the mocked output

      at Object.imageShortcode (_tests/imageShortcode.js:14:26)

  ● imageShortcode › should throw an error if image processing fails

    TypeError: imageShortcode is not a function

      26 |
      27 |     // Test that the error is thrown correctly
    > 28 |     await expect(imageShortcode("test-image.jpg", "Test Image")).rejects.toThrow("Image processing failed");
         |                  ^
      29 |   });
      30 | });
      31 |

      at Object.imageShortcode (_tests/imageShortcode.js:28:18)

Report generated by 🧪jest coverage report action from 83ba69f

@ximekilgsa ximekilgsa enabled auto-merge January 8, 2025 17:52
@wesley-dean-gsa
Copy link
Contributor

Pa11y testing results ```Running axe-core 4.8.4 in chrome-headless

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/404.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/about/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/about-the-dha/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/compensation-and-benefits/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/faq/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/federal-job-posting/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/hiring-process/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/newsletter/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/cloud-gov-account-manager-business-lead.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/tts-platforms-and-services-communities-and-collaboration-branch-chief.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/tts-office-of-solutions-fedramp-security-director.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/tts-fellowships-office-presidential-innovation-fellows-director.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/public-experience-contact-center-analyst.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/public-experience-content-and-outreach-branch-chief.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/tts-fellowships-office-presidential-innovation-fellows.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/tts-product-manager.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/tts-senior-software-engineer.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/tts-senior-advisor-for-technology.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/u-s-digital-corps-fellow-experience-supervisor.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/login-gov-data-engineer.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/login-gov-fraud-analyst.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/login-gov-fraud-technical-expert.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/login-gov-data-analyst.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/login-gov-technical-product-manager.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/tts-organizational-culture-development-specialist.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/tts-it-specialist.html ... please wait, this may take a minute.

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

1 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/join/resume/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/services/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/services/people/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/services/platforms/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/feature/tts-735-736/services/products/ ... please wait, this may take a minute.
0 violations found!
Testing complete of 33 pages

Please note that only 20% to 50% of all accessibility issues can automatically be detected.
Manual testing is always required. For more information see:
https://dequeuniversity.com/curriculum/courses/testingmethods

<!-- thollander/actions-comment-pull-request "pa11y" -->

@wesley-dean-gsa
Copy link
Contributor

wesley-dean-gsa commented Jan 8, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JSON jsonlint 1 0 0.21s
✅ JSON npm-package-json-lint yes no 0.31s
✅ JSON prettier 1 0 0 0.42s
✅ JSON v8r 1 0 1.41s
✅ REPOSITORY checkov yes no 13.73s
✅ REPOSITORY gitleaks yes no 0.2s
✅ REPOSITORY git_diff yes no 0.15s
✅ REPOSITORY grype yes no 10.01s
✅ REPOSITORY secretlint yes no 2.15s
✅ REPOSITORY trivy yes no 4.51s
✅ REPOSITORY trufflehog yes no 2.37s
✅ YAML prettier 1 0 0 0.65s
✅ YAML yamllint 1 0 0.26s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@ximekilgsa ximekilgsa merged commit 59257c9 into staging Jan 8, 2025
13 checks passed
@ximekilgsa ximekilgsa deleted the feature/tts-735-736 branch January 8, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants