Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update staging>main #709

Merged
merged 23 commits into from
Dec 18, 2024
Merged

Update staging>main #709

merged 23 commits into from
Dec 18, 2024

Conversation

debjudy
Copy link
Contributor

@debjudy debjudy commented Dec 18, 2024

Changes proposed in this pull request

security considerations

[Note the any security considerations here, or make note of why there are none]

@debjudy debjudy requested review from a team as code owners December 18, 2024 15:33
@wesley-dean-gsa
Copy link
Contributor

Preview This Branch

You may view the preview version of the site with the following URL:

https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/staging/

It may take a minute before changes in this Pull Request (PR) show up ⏱️

@wesley-dean-gsa
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.92% (-0.24% 🔻)
230/307
🟡 Branches 75.8% 166/219
🟢 Functions
80.65% (-2.69% 🔻)
25/31
🟡 Lines
74.92% (-0.24% 🔻)
230/307
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 global.js
91.89% (-0.84% 🔻)
91.74%
88.89% (-5.23% 🔻)
91.89% (-0.84% 🔻)

Test suite run failed

Failed tests: 2/83. Failed suites: 1/22.
  ● imageShortcode › should generate an img tag with the correct src and alt, using default class

    TypeError: imageShortcode is not a function

      12 |
      13 |     // Call imageShortcode and capture the result
    > 14 |     const result = await imageShortcode("test-image.jpg", "Test Image");
         |                          ^
      15 |
      16 |     // Ensure the result matches the expected HTML string
      17 |     expect(result).toBe(mockResult); // Check if the result matches the mocked output

      at Object.imageShortcode (_tests/imageShortcode.js:14:26)

  ● imageShortcode › should throw an error if image processing fails

    TypeError: imageShortcode is not a function

      26 |
      27 |     // Test that the error is thrown correctly
    > 28 |     await expect(imageShortcode("test-image.jpg", "Test Image")).rejects.toThrow("Image processing failed");
         |                  ^
      29 |   });
      30 | });
      31 |

      at Object.imageShortcode (_tests/imageShortcode.js:28:18)

Report generated by 🧪jest coverage report action from 7d743da

Copy link
Contributor

@wesley-dean-gsa wesley-dean-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @debjudy

@debjudy debjudy merged commit 61e8bf0 into main Dec 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants