Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Scorecard annotations #704

Closed
wants to merge 6 commits into from
Closed

Include Scorecard annotations #704

wants to merge 6 commits into from

Conversation

wesley-dean-gsa
Copy link
Contributor

Changes proposed in this pull request

This includes annotations for several Scorecard checks that are either not applicable or we can't support.

security considerations

@wesley-dean-gsa wesley-dean-gsa requested a review from a team as a code owner December 17, 2024 18:03
@wesley-dean-gsa
Copy link
Contributor Author

Preview This Branch

You may view the preview version of the site with the following URL:

https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/

It may take a minute before changes in this Pull Request (PR) show up ⏱️

@wesley-dean-gsa
Copy link
Contributor Author

wesley-dean-gsa commented Dec 17, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
74.92% (-0.24% 🔻)
 230/307
🟡 Branches 75.8% 166/219
🟢 Functions
80.65% (-2.69% 🔻)
 25/31
🟡 Lines
74.92% (-0.24% 🔻)
 230/307
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢 global.js
91.89% (-0.84% 🔻)
 91.74%
88.89% (-5.23% 🔻)
91.89% (-0.84% 🔻)

Test suite run failed

Failed tests: 2/83. Failed suites: 1/22. 
  ● imageShortcode › should generate an img tag with the correct src and alt, using default class

    TypeError: imageShortcode is not a function

      12 |
      13 |     // Call imageShortcode and capture the result
    > 14 |     const result = await imageShortcode("test-image.jpg", "Test Image");
         |                          ^
      15 |
      16 |     // Ensure the result matches the expected HTML string
      17 |     expect(result).toBe(mockResult); // Check if the result matches the mocked output

      at Object.imageShortcode (_tests/imageShortcode.js:14:26)

  ● imageShortcode › should throw an error if image processing fails

    TypeError: imageShortcode is not a function

      26 |
      27 |     // Test that the error is thrown correctly
    > 28 |     await expect(imageShortcode("test-image.jpg", "Test Image")).rejects.toThrow("Image processing failed");
         |                  ^
      29 |   });
      30 | });
      31 |

      at Object.imageShortcode (_tests/imageShortcode.js:28:18)

Report generated by 🧪jest coverage report action from 9a2a000

@wesley-dean-gsa
Copy link
Contributor Author

wesley-dean-gsa commented Dec 17, 2024 •
edited
Loading

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ MARKDOWN markdownlint 2 0 0 0.8s
✅ MARKDOWN markdown-link-check 2 0 1.12s
✅ MARKDOWN markdown-table-formatter 2 0 0 0.6s
✅ REPOSITORY checkov yes no 15.36s
✅ REPOSITORY gitleaks yes no 0.2s
✅ REPOSITORY git_diff yes no 0.14s
✅ REPOSITORY grype yes no 9.45s
✅ REPOSITORY secretlint yes no 2.15s
✅ REPOSITORY trivy yes no 4.92s
✅ REPOSITORY trufflehog yes no 2.38s
⚠️ SPELL cspell 2 1 2.99s
✅ YAML prettier 1 0 0 0.67s
✅ YAML v8r 1 0 1.69s
✅ YAML yamllint 1 0 0.35s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

wesley-dean-gsa and others added 2 commits December 17, 2024 18:05
@wesley-dean-gsa
[MegaLinter] Apply linters fixes
ff4c9b1
@wesley-dean-gsa
Update LICENSE.md
0e63407 
This ought to help the licencee API pick up on our license model
@wesley-dean-gsa wesley-dean-gsa requested a review from a team as a code owner December 17, 2024 18:19
@wesley-dean-gsa wesley-dean-gsa requested a review from a team as a code owner December 17, 2024 18:41
@wesley-dean-gsa wesley-dean-gsa deleted the scorecard branch December 17, 2024 18:44
@wesley-dean-gsa
Copy link
Contributor Author

Pa11y testing results ```Running axe-core 4.8.4 in chrome-headless

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/404.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/LICENSE.old/ ... please wait, this may take a minute.

Violation of "document-title" with 1 occurrences!
Ensures each HTML document contains a non-empty <title> element. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/document-title

Violation of "html-has-lang" with 1 occurrences!
Ensures every HTML document has a lang attribute. Correct invalid elements at:
- html
For details, see: https://dequeuniversity.com/rules/axe/4.8/html-has-lang

2 Accessibility issues detected.

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/about/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/overview/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/about-the-dha/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/compensation-and-benefits/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/faq/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/federal-job-posting/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/hiring-process/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/newsletter/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/cloud-gov-account-manager-business-lead.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/tts-platforms-and-services-communities-and-collaboration-branch-chief.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/tts-office-of-solutions-fedramp-security-director.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/tts-fellowships-office-presidential-innovation-fellows-director.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/public-experience-contact-center-analyst.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/public-experience-content-and-outreach-branch-chief.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/tts-fellowships-office-presidential-innovation-fellows.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/tts-product-manager.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/tts-senior-software-engineer.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/tts-senior-advisor-for-technology.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/u-s-digital-corps-fellow-experience-supervisor.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/login-gov-data-engineer.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/login-gov-fraud-analyst.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/login-gov-fraud-technical-expert.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/login-gov-data-analyst.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/login-gov-technical-product-manager.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/tts-organizational-culture-development-specialist.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/tts-it-specialist.html ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/join/resume/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/services/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/services/people/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/services/platforms/ ... please wait, this may take a minute.
0 violations found!

Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/scorecard/services/products/ ... please wait, this may take a minute.
0 violations found!
Testing complete of 35 pages

Please note that only 20% to 50% of all accessibility issues can automatically be detected.
Manual testing is always required. For more information see:
https://dequeuniversity.com/curriculum/courses/testingmethods

<!-- thollander/actions-comment-pull-request "pa11y" -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
TTS Website
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesley-dean-gsa