Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows #700

Merged
merged 13 commits into from
Dec 16, 2024
Merged

Update workflows #700

merged 13 commits into from
Dec 16, 2024

Conversation

wesley-dean-gsa
Copy link
Contributor

@wesley-dean-gsa wesley-dean-gsa commented Dec 16, 2024

Changes proposed in this pull request

  • pin Ubuntu version in anticipation of next month's change to a new default version of Ubuntu
  • Streamline tests action
  • adjust permissions
  • update PAT / GITHUB_TOKEN

security considerations

[Note the any security considerations here, or make note of why there are none]

Copy link

Preview This Branch

You may view the preview version of the site with the following URL:

https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/

It may take a minute before changes in this Pull Request (PR) show up ⏱️

@wesley-dean-gsa
Copy link
Contributor Author

wesley-dean-gsa commented Dec 16, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.92% (-0.24% 🔻)
230/307
🟡 Branches 75.8% 166/219
🟢 Functions
80.65% (-2.69% 🔻)
25/31
🟡 Lines
74.92% (-0.24% 🔻)
230/307
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 global.js
91.89% (-0.84% 🔻)
91.74%
88.89% (-5.23% 🔻)
91.89% (-0.84% 🔻)

Test suite run failed

Failed tests: 2/83. Failed suites: 1/22.
  ● imageShortcode › should generate an img tag with the correct src and alt, using default class

    TypeError: imageShortcode is not a function

      12 |
      13 |     // Call imageShortcode and capture the result
    > 14 |     const result = await imageShortcode("test-image.jpg", "Test Image");
         |                          ^
      15 |
      16 |     // Ensure the result matches the expected HTML string
      17 |     expect(result).toBe(mockResult); // Check if the result matches the mocked output

      at Object.imageShortcode (_tests/imageShortcode.js:14:26)

  ● imageShortcode › should throw an error if image processing fails

    TypeError: imageShortcode is not a function

      26 |
      27 |     // Test that the error is thrown correctly
    > 28 |     await expect(imageShortcode("test-image.jpg", "Test Image")).rejects.toThrow("Image processing failed");
         |                  ^
      29 |   });
      30 | });
      31 |

      at Object.imageShortcode (_tests/imageShortcode.js:28:18)

Report generated by 🧪jest coverage report action from 884b5f0

Copy link

github-actions bot commented Dec 16, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 7 0 0.05s
✅ REPOSITORY checkov yes no 13.39s
✅ REPOSITORY gitleaks yes no 0.2s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY grype yes no 9.69s
✅ REPOSITORY secretlint yes no 2.11s
✅ REPOSITORY trivy yes no 3.94s
✅ REPOSITORY trufflehog yes no 2.31s
✅ YAML prettier 7 0 0 0.46s
✅ YAML v8r 7 0 3.24s
✅ YAML yamllint 7 0 0.27s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@wesley-dean-gsa wesley-dean-gsa marked this pull request as ready for review December 16, 2024 14:56
@wesley-dean-gsa wesley-dean-gsa requested a review from a team as a code owner December 16, 2024 14:56
@wesley-dean-gsa wesley-dean-gsa changed the title Update test.yml Update workflows Dec 16, 2024
@wesley-dean-gsa wesley-dean-gsa merged commit 46bba36 into staging Dec 16, 2024
13 checks passed
@wesley-dean-gsa wesley-dean-gsa deleted the wesley-dean-gsa-patch-2 branch December 16, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants