Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redirect_from test #1236

Merged
merged 10 commits into from
Apr 26, 2024
Merged

add redirect_from test #1236

merged 10 commits into from
Apr 26, 2024

Conversation

mitchellhenke
Copy link
Contributor

🛠 Summary of changes

This adds a test so that we do not internally link to pages that have been moved.

@mitchellhenke mitchellhenke requested a review from aduth April 26, 2024 15:50
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/redirect-from-test branch from 6d53518 to 19c90f3 Compare April 26, 2024 15:50
aduth
aduth previously approved these changes Apr 26, 2024
spec/all_pages_spec.rb Outdated Show resolved Hide resolved
spec/all_pages_spec.rb Outdated Show resolved Hide resolved
zachmargolis
zachmargolis previously approved these changes Apr 26, 2024
spec/all_pages_spec.rb Outdated Show resolved Hide resolved
mitchellhenke and others added 2 commits April 26, 2024 12:06
Co-authored-by: Zach Margolis <[email protected]>
Co-authored-by: Zach Margolis <[email protected]>
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/redirect-from-test branch from c0ffcd3 to 33710b1 Compare April 26, 2024 17:50
@mitchellhenke mitchellhenke requested a review from aduth April 26, 2024 18:33
aduth
aduth previously approved these changes Apr 26, 2024
_config.yml Show resolved Hide resolved
_includes/help/nav_sidenav.html Outdated Show resolved Hide resolved
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mitchellhenke mitchellhenke merged commit ab27dfe into main Apr 26, 2024
14 checks passed
@mitchellhenke mitchellhenke deleted the mitchellhenke/redirect-from-test branch April 26, 2024 19:13
mitchellhenke added a commit that referenced this pull request May 6, 2024
* add redirect_from test

* Update spec/all_pages_spec.rb

Co-authored-by: Andrew Duthie <[email protected]>

* flat_map

* slight refactor on help pages

* fix links

* Update spec/all_pages_spec.rb

Co-authored-by: Zach Margolis <[email protected]>

* Update spec/all_pages_spec.rb

Co-authored-by: Zach Margolis <[email protected]>

* fix subpage nav

* add help prepend to config

* delete translate_page

---------

Co-authored-by: Andrew Duthie <[email protected]>
Co-authored-by: Zach Margolis <[email protected]>
mitchellhenke added a commit that referenced this pull request May 6, 2024
* add redirect_from test

* Update spec/all_pages_spec.rb

Co-authored-by: Andrew Duthie <[email protected]>

* flat_map

* slight refactor on help pages

* fix links

* Update spec/all_pages_spec.rb

Co-authored-by: Zach Margolis <[email protected]>

* Update spec/all_pages_spec.rb

Co-authored-by: Zach Margolis <[email protected]>

* fix subpage nav

* add help prepend to config

* delete translate_page

---------

Co-authored-by: Andrew Duthie <[email protected]>
Co-authored-by: Zach Margolis <[email protected]>
mitchellhenke added a commit that referenced this pull request May 6, 2024
* add redirect_from test

* Update spec/all_pages_spec.rb

Co-authored-by: Andrew Duthie <[email protected]>

* flat_map

* slight refactor on help pages

* fix links

* Update spec/all_pages_spec.rb

Co-authored-by: Zach Margolis <[email protected]>

* Update spec/all_pages_spec.rb

Co-authored-by: Zach Margolis <[email protected]>

* fix subpage nav

* add help prepend to config

* delete translate_page

---------

Co-authored-by: Andrew Duthie <[email protected]>
Co-authored-by: Zach Margolis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants