-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add redirect_from test #1236
Merged
Merged
add redirect_from test #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d53518
to
19c90f3
Compare
aduth
previously approved these changes
Apr 26, 2024
Co-authored-by: Andrew Duthie <[email protected]>
zachmargolis
previously approved these changes
Apr 26, 2024
Co-authored-by: Zach Margolis <[email protected]>
Co-authored-by: Zach Margolis <[email protected]>
aduth
reviewed
Apr 26, 2024
c0ffcd3
to
33710b1
Compare
aduth
previously approved these changes
Apr 26, 2024
aduth
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
mitchellhenke
added a commit
that referenced
this pull request
May 6, 2024
* add redirect_from test * Update spec/all_pages_spec.rb Co-authored-by: Andrew Duthie <[email protected]> * flat_map * slight refactor on help pages * fix links * Update spec/all_pages_spec.rb Co-authored-by: Zach Margolis <[email protected]> * Update spec/all_pages_spec.rb Co-authored-by: Zach Margolis <[email protected]> * fix subpage nav * add help prepend to config * delete translate_page --------- Co-authored-by: Andrew Duthie <[email protected]> Co-authored-by: Zach Margolis <[email protected]>
mitchellhenke
added a commit
that referenced
this pull request
May 6, 2024
* add redirect_from test * Update spec/all_pages_spec.rb Co-authored-by: Andrew Duthie <[email protected]> * flat_map * slight refactor on help pages * fix links * Update spec/all_pages_spec.rb Co-authored-by: Zach Margolis <[email protected]> * Update spec/all_pages_spec.rb Co-authored-by: Zach Margolis <[email protected]> * fix subpage nav * add help prepend to config * delete translate_page --------- Co-authored-by: Andrew Duthie <[email protected]> Co-authored-by: Zach Margolis <[email protected]>
mitchellhenke
added a commit
that referenced
this pull request
May 6, 2024
* add redirect_from test * Update spec/all_pages_spec.rb Co-authored-by: Andrew Duthie <[email protected]> * flat_map * slight refactor on help pages * fix links * Update spec/all_pages_spec.rb Co-authored-by: Zach Margolis <[email protected]> * Update spec/all_pages_spec.rb Co-authored-by: Zach Margolis <[email protected]> * fix subpage nav * add help prepend to config * delete translate_page --------- Co-authored-by: Andrew Duthie <[email protected]> Co-authored-by: Zach Margolis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This adds a test so that we do not internally link to pages that have been moved.