Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace raw color tokens with stateful alternatives #1220

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Mar 7, 2024

🛠 Summary of changes

Replaces instances of "green" and "red" design system color tokens with equivalent "success" and "error" tokens.

This is an incremental step toward upgrading to the latest version of the design system, which removes raw color tokens. As noted in the CHANGELOG, these colors are also incorrect.

📜 Testing Plan

  1. Visit affected pages to verify that the icon list icons appear in the expected green and red colors:
    1. https://federalist-17bd62cc-77b7-4687-9c62-39b462ce6fd5.sites.pages.cloud.gov/preview/gsa-tts/identity-site/aduth-stateful-colors/help/verify-your-identity/accepted-identification-documents/
    2. https://federalist-17bd62cc-77b7-4687-9c62-39b462ce6fd5.sites.pages.cloud.gov/preview/gsa-tts/identity-site/aduth-stateful-colors/help/verify-your-identity/how-to-add-images-of-your-state-issued-id/

📸 Screenshots

As noted above, the raw color tokens have always been slightly inconsistent with the expected stateful colors, so there is expected to be a slight color difference here.

Before After
image image

cc for review: @night-jellyfish @charleyf @dawei-nava

@mitchellhenke mitchellhenke force-pushed the aduth-stateful-colors branch from 59c5d3a to a87ba06 Compare March 7, 2024 18:37
@aduth aduth merged commit 6d708f0 into main Mar 7, 2024
14 checks passed
@aduth aduth deleted the aduth-stateful-colors branch March 7, 2024 19:46
@night-jellyfish
Copy link
Contributor

night-jellyfish commented Mar 7, 2024

Thanks for tagging us! It's already merged and looks good to me, but I just want to tag @kellular as well.

Edit: tag wasn't initially working, but after posting it did work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants