Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct circular imports for PTT #138

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Correct circular imports for PTT #138

merged 1 commit into from
Nov 13, 2023

Conversation

brmather
Copy link
Collaborator

Conda was failing because of circular imports.

Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/gplately_1699874743383/test_tmp/run_test.py", line 2, in <module>
    import gplately
  File "/home/conda/feedstock_root/build_artifacts/gplately_1699874743383/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.11/site-packages/gplately/__init__.py", line 176, in <module>
    from . import (
  File "/home/conda/feedstock_root/build_artifacts/gplately_1699874743383/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.11/site-packages/gplately/grids.py", line 40, in <module>
    from .reconstruction import PlateReconstruction as _PlateReconstruction
  File "/home/conda/feedstock_root/build_artifacts/gplately_1699874743383/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.11/site-packages/gplately/reconstruction.py", line 11, in <module>
    from . import ptt
ImportError: cannot import name 'ptt' from partially initialized module 'gplately' (most likely due to a circular import) (/home/conda/feedstock_root/build_artifacts/gplately_1699874743383/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.11/site-packages/gplately/__init__.py)
WARNING: Tests failed for gplately-1.2.1-pyhd8ed1ab_0.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
TESTS FAILED: gplately-1.2.1-pyhd8ed1ab_0.conda
##[error]Bash exited with code '1'.

@brmather brmather linked an issue Nov 13, 2023 that may be closed by this pull request
@brmather brmather merged commit eda0ab2 into master Nov 13, 2023
13 checks passed
@brmather brmather deleted the circular_imports branch November 13, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct circular imports
1 participant