Submodules #46
Open
Submodules #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the submodules of GIDAAlertView and GIDACalculateString. So that the versions can be updated without the copy paste and have the same standard version in all systems.
Adds the submodules of GIDAAlertView and GIDACalculateString. So that the versions can be updated without the copy paste and have the same standard version in all systems.
|
The build crashes until GIDAAlertView and GIDACalculateString are pulled. |
|
I'm checking this, updating Xcode right now though :( |
|
@aparedes I cannot get this to work on my machine, Xcode still shows me the files as missing even after I ran init in the submodules. Do you know if there's something special that I have to do? |
|
You can try On Wed, Mar 12, 2014 at 7:41 PM, Yoshiki Vázquez Baeza
|
|
Doesn't seem to be working either, also note that since the repo just switched to being public, it seems like all of our forks were disabled, make sure you go to your repo on github and enable it via the settings page. |
|
|
| @@ -0,0 +1 @@ | |||
| Subproject commit eed9ecd02791ff6a051174d2f53b0b84be170b89 | |||
There was a problem hiding this comment.
I think this has to be changed now that https://github.com/GIDAIbero/GIDAAlertView has been updated.
|
Thanks @aparedes it's now working though now I think the REF has to be updated for the build to not fail. |
|
Btw, wouldn't it be nice to do the same thing on the Android version with the MatrixSolver package? |
|
@SantiagoTorres Yes!! |
|
Yeah the REF changes. That is because you need to verify that the updates of the submodule work for the project. If not just stay with the same version. |
|
Ok, now that GIDAIbero/GIDACalculateString#5 was merged, I think the HEAD of GIDACalculateString needs to be updated in this project, right? Would you mind doing that so I can check everything is kosher? |
|
I'm getting 34 warnings :S |
|
What classes show the warnings? I can not reproduce |
MATSOL Group
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/ScrollViewController.m
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/ScrollViewController.m:169:16: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/DecoderViewController.m
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/DecoderViewController.m:142:91: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/DecoderViewController.m:144:79: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/DecoderViewController.m:148:94: Implicit conversion loses integer precision: 'long' to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/DecoderViewController.m:150:82: Implicit conversion loses integer precision: 'long' to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/DecoderViewController.m:161:13: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/DecoderViewController.m:162:14: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/DecoderViewController.m:163:8: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/DecoderViewController.m:174:12: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/DecoderViewController.m:184:103: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/DecoderViewController.m:188:146: Implicit conversion loses integer precision: 'long' to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/BaseConverterViewController.m
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/BaseConverterViewController.m:246:22: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/Classes/BaseConverterViewController.m:310:17: Implicit conversion loses integer precision: 'long' to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:100:17: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:103:21: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:175:21: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:201:87: Implicit conversion loses integer precision: 'unsigned long' to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:208:67: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:215:67: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:222:67: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:229:67: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:236:67: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:244:67: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:246:78: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:408:33: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:434:29: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:461:33: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:467:25: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:473:21: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/External/GIDACalculateString/GIDACalculateString.m:491:52: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/GIDAUtilities/GIDAMatrixViewController.m
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/GIDAUtilities/GIDAMatrixViewController.m:487:22: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/GIDAUtilities/GIDAMatrixViewController.m:566:23: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/GIDAUtilities/GIDAMatrixViewController.m:590:27: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'
/Users/yoshikivazquezbaeza/git_sw/MATSOL/MATSOL/GIDAUtilities/GIDAMatrixViewController.m:387:1: Conflicting return type in implementation of 'numberOfSectionsInTableView:': 'NSInteger' (aka 'long') vs 'int' |
|
Got to love that NSInteger is, in fact, a long. Are you compiling for the proper architecture? There used to be a bug that some frameworks linked with their MacOSX counterparts, I don't know if it's still around tho. I'm pretty sure one of you guys is compiling for 64-bit and the other one isn't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the submodules of GIDAAlertView and GIDACalculateString. So that the versions can be updated without the copy paste and have the same standard version in all systems.