Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License #45

Merged
merged 3 commits into from
Mar 12, 2014
Merged

License #45

merged 3 commits into from
Mar 12, 2014

Conversation

aparedes
Copy link
Member

@aparedes aparedes commented Mar 9, 2014

Let us discuss this and then we can approach the "BOSS"

aparedes added 2 commits March 9, 2014 16:14
@aparedes
Adds License GPLv3 for MATSOL for iOS
c65d6cb 
Adds the GPLv3 license file to the repository.
@aparedes
Updates README.md
a06bdfa 
Updates README.md file with information about the project.
@SantiagoTorres
Copy link
Member

I'll check this later today.

@SantiagoTorres SantiagoTorres self-assigned this Mar 9, 2014
SantiagoTorres
SantiagoTorres reviewed Mar 10, 2014
View reviewed changes
README.md

## Attribution
MATSOL for iOS uses also this components also:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be
MATSOL for iOS uses these GidaIbero components also:

@SantiagoTorres
Copy link
Member

I have two concerns with this.

@aparedes
Copy link
Member Author

  • I agree if its was our source code, it should be Beerware but as the code is really property of GIDAIbero, I think the right way to go is GPL to make the code freeware. But as I am open to it.
  • 44 is only images, and if this code goes open then it should be merged.

@SantiagoTorres
Copy link
Member

  • I guess you are right, we should use GPL, I might as well update the license in the Android version too

ElDeveloper
ElDeveloper reviewed Mar 10, 2014
View reviewed changes
README.md
## Contents

+ Linear equation solver. Using [Gauss-Jordan](http://en.wikipedia.org/wiki/Gaussian_elimination) method for solving Linear Systems
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should link to [Numerical recipes in C] as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok will add it too

@ElDeveloper
Copy link
Member

Agreed on making this GPL as well as changing this in MATSOL Android.

@aparedes
Changes README.md
933a514 
+ Adds Numerical Recipes in C for Linear equation solver.
+ Specifies that components used are from GIDAIBero
ElDeveloper added a commit that referenced this pull request Mar 12, 2014
@ElDeveloper
Merge pull request #45 from aparedes/license
417eb73 
License
@ElDeveloper ElDeveloper merged commit 417eb73 into GIDAIbero:master Mar 12, 2014
@ElDeveloper
Copy link
Member

🍻

@aparedes aparedes deleted the license branch March 13, 2014 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SantiagoTorres SantiagoTorres

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aparedes @SantiagoTorres @ElDeveloper