Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Complex #4

wants to merge 4 commits into from

Conversation

aparedes
Copy link
Member

There is still some bugs to fix or to find.
Please review it when you have time and test it as much as you can and let me know any issues :D

Interface for the keyboard, so that it can easily be copyied and used, and no
need to create a keyboard with the accesoryview
Allows the input and calculation of an equation with i or √- elements
There is also a special object ComplexObject that contains the real
and imaginary numbers. Also has an interface for printing as a string.
@ElDeveloper
Copy link
Member

Hey, this is really cool, this is going to be a major addition to MATSOL. I've made a couple comments on some minor details I noticed on the code. And also found the following statements that didn't seem to work with the parser:

(12+58-√8i)*1

25√5

1+√-i

1*√i

The interface would not allow me to write a as a first character.

And overall I think that if we have an exception to catch when these problems happen and then a dialog is shown on screen directing people to a contact e-mail or to this repository, I think that would make the most sense. But that's just an alternative.

This is an amazing amazing advancement, cheers!! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants