Code

[NDSL] UW Convection port#993

Code

Open

katrinafandrich wants to merge 56 commits intodsl/developGEOS-ESM/GEOSgcm_GridComp:dsl/developfrom dsl/UW_convectionGEOS-ESM/GEOSgcm_GridComp:dsl/UW_convectionCopy head branch name to clipboard

+10,455-1

Commits

Commits on Aug 14, 2024

• SaturationVaporPressureTable code first pass

  Show description for b30ae8d
  FlorianDeconinck

  committed
  b30ae8d

  Copy full SHA for b30ae8d

• QSat_Ice_scalar_exact

  FlorianDeconinck

  committed
  cde8399

  Copy full SHA for cde8399

• Fix calculation. Table generates OK.

  FlorianDeconinck

  committed
  dd15d29

  Copy full SHA for dd15d29

• Fix Murphy and CAM

  FlorianDeconinck

  committed
  e6b597c

  Copy full SHA for e6b597c

Commits on Aug 15, 2024

• Rename estimate_table -> table

  Show description for 5e4e464
  FlorianDeconinck

  committed
  5e4e464

  Copy full SHA for 5e4e464

Commits on Aug 28, 2024

• Functional QSat module. Can handle optional RAMP/PASCALS/DQSAT inputs. Fails to verify at majority of points using original metric, has not been tested with new metrics. Error patterns of the ES ta…

  Show description for b80185c
  CharlesKrop

  committed
  b80185c

  Copy full SHA for b80185c

• More clean up, first attempt at QSat function

  CharlesKrop

  committed
  1065cff

  Copy full SHA for 1065cff

• [NDSL] Porting slope and conden in UW_Convection Port

  

  Katrina Fandrich

  committed
  7b8363d

  Copy full SHA for 7b8363d

• Working QSat function. QSat class can still be called outside of stencil to calculate QSat for entire field, or function can be called from within the stencil to calculate QSat at individual points…

  Show description for 76b6ec5
  CharlesKrop

  committed
  76b6ec5

  Copy full SHA for 76b6ec5

• Merged dsl/QSat into dsl/UW_convection

  

  Katrina Fandrich

  committed
  ed6025a

  Copy full SHA for ed6025a

Commits on Aug 29, 2024

• Adding QSat_Floatfield function

  

  Katrina Fandrich

  committed
  e5b6f5b

  Copy full SHA for e5b6f5b

• Merge remote-tracking branch 'origin/dsl/QSat' into dsl/UW_convection

  

  Katrina Fandrich

  committed
  bda3121

  Copy full SHA for bda3121

Commits on Aug 30, 2024

• [NDSL] Translate test for conden passes 1/7 vars. Errors are very very small.

  

  Katrina Fandrich

  committed
  bb2f2f7

  Copy full SHA for bb2f2f7

Commits on Sep 3, 2024

• [NDSL] Ported and partially verified conden. Small errors likely from QSat function.

  

  Katrina Fandrich

  committed
  996b2c5

  Copy full SHA for 996b2c5

Commits on Sep 10, 2024

• [NDSL] Began porting larger subroutine compute_uwshcu in UWConvection port

  

  Katrina Fandrich

  committed
  12b33c7

  Copy full SHA for 12b33c7

• [NDSL] Early stages of porting and verifying compute_uwshcu. Need to deal with reshaping 2D and 3D variables in translate test before calling stencil computation.

  

  Katrina Fandrich

  committed
  c316ac6

  Copy full SHA for c316ac6

Commits on Sep 11, 2024

• Resolved merge conflict in .gitignore [#993]

  

  Katrina Fandrich

  committed
  5d55e83

  Copy full SHA for 5d55e83

• [NDSL] Adding type FloatField_NTracers to deal with 4D quantities in compute_uwshcu

  

  Katrina Fandrich

  committed
  8ca0e30

  Copy full SHA for 8ca0e30

• Resolving merge conflicts before merging dsl/develop with dsl/UWConvection

  

  Katrina Fandrich

  committed
  88f7dff

  Copy full SHA for 88f7dff

• [NDSL] Created UW directory and added README.md

  

  Katrina Fandrich

  committed
  72e459e

  Copy full SHA for 72e459e

• Removed uwshcu.F90.SER from branch. Need to make a separate PR for serialization.

  

  Katrina Fandrich

  committed
  71e7883

  Copy full SHA for 71e7883

Commits on Sep 12, 2024

• [NDSL] Broke up slope stencil into 2 functions. Translate test fails, but errors are very very small.

  

  Katrina Fandrich

  committed
  a637851

  Copy full SHA for a637851

Commits on Sep 17, 2024

• [NDSL] Working slope function. Translate compute_uwshcu.py fails for 2/6 variables. Some errors are very small and likely stem from multiplication with constants.

  

  Katrina Fandrich

  committed
  24a91c1

  Copy full SHA for 24a91c1

Commits on Sep 18, 2024

• [NDSL] Ported and verified first section of compute_uwshcu. 5/6 variable pass. Very small errors still exist in 'ssthl0_test' that likely stem from multiplication with constants. A bug was found wh…

  Show description for 1cb1ef1
  

  Katrina Fandrich

  committed
  1cb1ef1

  Copy full SHA for 1cb1ef1

Commits on Sep 20, 2024

• [NDSL] Updated compute_uwshcu and translate test with next section of compute_uwshcu

  

  Katrina Fandrich

  committed
  1391419

  Copy full SHA for 1391419

• Merge branch 'dsl/develop' into dsl/UW_convection

  

  Katrina Fandrich

  committed
  654bc09

  Copy full SHA for 654bc09

• [NDSL] Removed workaround/bug fix. Still debugging compute_uwshcu

  

  Katrina Fandrich

  committed
  4f6ce92

  Copy full SHA for 4f6ce92

Commits on Sep 25, 2024

• [NDSL] Still working on verifying compute_uwshcu. 5 variables still failing.

  

  Katrina Fandrich

  committed
  2107162

  Copy full SHA for 2107162

Commits on Sep 26, 2024

• [NDSL] Updated RGAS constant and linting in compute_uwshcu

  

  Katrina Fandrich

  committed
  814eec4

  Copy full SHA for 814eec4

• [NDLS] Semi-working version of compute_uwshcu. 3 variables still fail at less than 1%. Switched ndsl branches to unstable/develop.

  

  Katrina Fandrich

  committed
  d248b2f

  Copy full SHA for d248b2f

• [NDSL] Updated README and deleted conden.py and slope.py. Starting last part of compute_uwshcu port.

  

  Katrina Fandrich

  committed
  29bb7f7

  Copy full SHA for 29bb7f7

Commits on Oct 2, 2024

• Added MAPL_UNDEF. As of now, this constant is set to 1E15 but will be changed at some point.

  

  Katrina Fandrich

  committed
  f27d9c7

  Copy full SHA for f27d9c7

• [NDSL] Working version of compute_uwshcu. 3 variables fail at less than 0.01% of grid points. Still need to raise errors when unported code is triggered and cleanup.

  

  Katrina Fandrich

  committed
  3aae569

  Copy full SHA for 3aae569

Commits on Oct 3, 2024

• [NDSL] Updated README.md and added flags to raise errors when parts of the compute_uwshcu are triggered that have not yet been ported.

  

  Katrina Fandrich

  committed
  c65eae0

  Copy full SHA for c65eae0

Commits on Oct 4, 2024

• Merge branch 'dsl/develop' into dsl/UW_convection

  FlorianDeconinck

  authored
  52758c8

  Copy full SHA for 52758c8

Commits on Oct 7, 2024

• [NDSL] Updated README.md and cleaned up compute_uwshcu. Still need to edit a few variable descriptions.

  

  Katrina Fandrich

  committed
  d8f22e5

  Copy full SHA for d8f22e5

• Merge branch 'dsl/UW_convection' of github.com:GEOS-ESM/GEOSgcm_GridComp into dsl/UW_convection

  

  Katrina Fandrich

  committed
  65b45ae

  Copy full SHA for 65b45ae

Commits on Oct 15, 2024

• Merge remote-tracking branch 'NASA/dsl/develop' into dsl/UW_convection

  FlorianDeconinck

  committed
  f0e99d6

  Copy full SHA for f0e99d6

• Fix merge w/ constants replacements in UW

  FlorianDeconinck

  committed
  20ccb6a

  Copy full SHA for 20ccb6a

• Swap Conden test for ComputeUwshcu

  FlorianDeconinck

  committed
  7614c3a

  Copy full SHA for 7614c3a

Commits on Oct 22, 2024

• [NDSL] Beginning stages of porting and translating smaller functions in uwshcu.F90. Including 'roots', 'compute_alpha', and 'single_cin'. Some translate tests may fail due to nans.

  

  Katrina Fandrich

  committed
  b89527c

  Copy full SHA for b89527c

• Merge branch 'dsl/UW_convection' of github.com:GEOS-ESM/GEOSgcm_GridComp into dsl/UW_convection

  

  Katrina Fandrich

  committed
  8c63561

  Copy full SHA for 8c63561

Commits on Oct 23, 2024

• [NDSL] Semi-working version of QsInvert. Translate test fails at many gridpoints, most likely due to mixed precision problem.

  

  Katrina Fandrich

  committed
  5fc18c6

  Copy full SHA for 5fc18c6

Commits on Oct 29, 2024

• [NDSL] Ported/tested several functions that are part of compute_uwshcu. Several functions fail at some gridpoints, but mostly passing overall. Moving on and will revisit failed tests later.

  

  Katrina Fandrich

  committed
  4d6eaae

  Copy full SHA for 4d6eaae

Commits on Nov 6, 2024

• Ported and verified fluxbelowinv and made minor updates to other functions

  

  Katrina Fandrich

  committed
  17a82b1

  Copy full SHA for 17a82b1

Commits on Nov 7, 2024

• Ported and verified positive_moisture_single. All gridpoints pass except the expected nans.

  

  Katrina Fandrich

  committed
  df6f497

  Copy full SHA for df6f497

• Updated README.md

  

  Katrina Fandrich

  committed
  df9c06c

  Copy full SHA for df9c06c

• Working version of qsinvert and translate test. Passes for all gridpoints except expected nans. Should be run with debug backend for now.

  

  Katrina Fandrich

  committed
  572f32d

  Copy full SHA for 572f32d

Commits on Dec 3, 2024

• Updated versions of compute_uwschu and translate test. Old versions still exist, will delete later.

  

  Katrina Fandrich

  committed
  f8cabef

  Copy full SHA for f8cabef

Commits on Dec 5, 2024

• Testing implicit_cin_closure still in progress. Several variables not passing translate test: tkeavg, uavg, vavg, thvlavg.

  

  Katrina Fandrich

  committed
  42b84f5

  Copy full SHA for 42b84f5

Commits on Dec 6, 2024

• Updated compute_uwshcu. Testing implicit_cin_closure in progress.

  

  Katrina Fandrich

  committed
  0cdcd60

  Copy full SHA for 0cdcd60

Commits on Dec 19, 2024

• Updated compute_uwshcu. Tested and verified up until "compute convective inhibition".

  

  Katrina Fandrich

  committed
  8f0e030

  Copy full SHA for 8f0e030

Commits on Dec 27, 2024

• Updated compute_uwshcu and translate test

  

  Katrina Fandrich

  committed
  c6f3596

  Copy full SHA for c6f3596

Commits on Jan 6, 2025

• More updates. If/else block in implicit_cin_closure still failing

  

  Katrina Fandrich

  committed
  80f619e

  Copy full SHA for 80f619e

Commits on Jan 16, 2025

• UW updates

  

  Katrina Fandrich

  committed
  95964c7

  Copy full SHA for 95964c7

Commits on Jan 17, 2025

• Restructured big if/else in UW

  

  Katrina Fandrich

  committed
  145172d

  Copy full SHA for 145172d